chrome_public_test_apk failing on 3 builders |
||||
Issue descriptionSeeing failures in org.chromium.chrome.browser.omnibox.OmniboxTest#testFocusChangingSoftInputMode org.chromium.chrome.browser.contextualsearch.ContextualSearchManagerTest#testHidesWhenOmniboxFocused and suspect the following change: Change #61471 Changed by mdjones@chromium.org Changed at Fri 31 Mar 2017 09:06:11 Repository https://chromium.googlesource.com/chromium/src Project src Branch master Revision be3c0a00c44fafc9bc740764569273a688fe6c6a Comments [Home] Prevent content jump when navigating from bottom sheet When the omnibox is focused the soft input mode is switched from resize to pan. When changing back in Chrome Home, the window would pan to attempt to keep the input visible (which is a moving target in Chrome Home). This change sets the input mode to do nothing for both normal and Chrome Home cases. BUG=706918 Review-Url: https://codereview.chromium.org/2790733002 Cr-Commit-Position: refs/heads/master@{#461136} Changed files chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarPhone.java chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/OmniboxTest.java chrome_public_test_apk failing on 3 builders Builders failed on: - KitKat Tablet Tester: https://build.chromium.org/p/chromium.android/builders/KitKat%20Tablet%20Tester - Lollipop Tablet Tester: https://build.chromium.org/p/chromium.android/builders/Lollipop%20Tablet%20Tester - Marshmallow Tablet Tester: https://build.chromium.org/p/chromium.android/builders/Marshmallow%20Tablet%20Tester
,
Apr 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f0433e75d2158112feb6be25d52c60d0c7f80e77 commit f0433e75d2158112feb6be25d52c60d0c7f80e77 Author: mdjones <mdjones@chromium.org> Date: Sat Apr 01 01:35:11 2017 Fix tablet input mode test Update LocationBarTablet to match the soft input mode that LocationBarPhone uses (SOFT_INPUT_ADJUST_RESIZE to SOFT_INPUT_ADJUST_NOTHING). BUG= 707383 Review-Url: https://codereview.chromium.org/2788263002 Cr-Commit-Position: refs/heads/master@{#461302} [modify] https://crrev.com/f0433e75d2158112feb6be25d52c60d0c7f80e77/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarTablet.java
,
Apr 3 2017
,
Apr 4 2017
This is still happening on runs after the fix landed. See https://uberchromegw.corp.google.com/i/chromium.android/builders/KitKat%20Tablet%20Tester/builds/7182, which included the fix.
,
Apr 4 2017
That test has been flaky for a while and was recently disabled here: https://bugs.chromium.org/p/chromium/issues/detail?id=707529 I'll use that bug to track the issue. |
||||
►
Sign in to add a comment |
||||
Comment 1 by mdjones@chromium.org
, Mar 31 2017