Improve sad tab strings to make sad tab more actionable |
||||||||||||||||||||||
Issue descriptionFeature description: Add new header text + new description text formatted in a new way, both to appear only on the sad tab that shows "Send Feedback". Eng owner: twellington Product owner: yyushkina Mocks: go/better-sad-tab-strings Design doc: None as string changes only Are you planning on experimenting before launch? No, since string changes only Any new strings? Yes, already checked in and localized Any implications for Google webservices (i.e. sync, translate)? No Binary size? N/A Do the existing perf tests exercise all aspects of your new feature(s)? Yes
,
Apr 4 2017
M60 is great. Thank you!
,
Apr 18 2017
Android mocks here: https://docs.google.com/presentation/d/12CnqtmscCCaFFgBG8uCGum3ed1-vbFOYR5UFLfavujs/edit#slide=id.g1c3ddfdc9b_0_99 After initial investigation, we should look at using BulletSpan for the bullet formatting.
,
May 8 2017
Issue 665237 changed the "reload" button to "send feedback" after successive crashes. Linking here for reference.
,
May 9 2017
Screenshots attached from in-flight patch (https://codereview.chromium.org/2866273003). For testing, I've been using these steps: 1. Connect to GIN-2g-poor 2. Load a URL 3. Go to chrome://crash 4. Click the reload button 5. Before the page can finish loading, go to chrome://crash again https://sites.google.com/a/google.com/corp-netops/focusareas/wireless/projects/googleguest-c?pli=1
,
May 9 2017
Just confirming because I can't tell from looking at it: is it 5 character spaces before the bullet 4 character spaces after the bullet and before its text?
,
May 9 2017
No. Android doesn't allow spaces before the bullet; it must be the first thing on the line. There is 12dp of padding before the bullets and a configurable 100 gap width after the bullet. It's easy to adjust these if needed. Is there a UX designer we can CC to advise on the correct values to use for the padding and gap width? Looking at the screenshots blown up, the bullet appears to be getting cut off on the left edge and the margin is too big, so I can adjust those.
,
May 9 2017
Shimi - could you chime in on this/corral the designers one more time?
,
May 9 2017
I converted the gap width to DP so that it positions more consistently across devices. This is with 12dp padding in front of the bullet + 2dp extra inset to avoid bullet clipping + 15dp gap after the bullet on a Nexus 9 and Nexus 6P.
,
May 10 2017
Hi - UX had specified the padding in character spaces to be platform- independent. Here's how it translates in dp: Between margin and bullet (padding): 16 dp / 5 character spaces Between bullet and text (gap width): 12dp / 4 character spaces Reason is so text lines up nicely if there are other elements on the page like radio buttons. On this page, there aren't any, but we're trying to future-proof and develop a standard that works in various cases.
,
May 10 2017
That looks perfect now. Thanks for all the adjustments.
,
May 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/91d3ee3c63734399ce574d0ed71f4004fb7e8605 commit 91d3ee3c63734399ce574d0ed71f4004fb7e8605 Author: twellington <twellington@chromium.org> Date: Thu May 11 01:17:28 2017 [Android] Improve sad tab strings Add new header text and more descriptive body text when a tab has crashed multiple times in a row. BUG= 707352 Review-Url: https://codereview.chromium.org/2866273003 Cr-Commit-Position: refs/heads/master@{#470768} [modify] https://crrev.com/91d3ee3c63734399ce574d0ed71f4004fb7e8605/chrome/BUILD.gn [modify] https://crrev.com/91d3ee3c63734399ce574d0ed71f4004fb7e8605/chrome/android/BUILD.gn [modify] https://crrev.com/91d3ee3c63734399ce574d0ed71f4004fb7e8605/chrome/android/java/res/layout/sad_tab.xml [modify] https://crrev.com/91d3ee3c63734399ce574d0ed71f4004fb7e8605/chrome/android/java/res/values-v17/styles.xml [modify] https://crrev.com/91d3ee3c63734399ce574d0ed71f4004fb7e8605/chrome/android/java/res/values/dimens.xml [modify] https://crrev.com/91d3ee3c63734399ce574d0ed71f4004fb7e8605/chrome/android/java/src/org/chromium/chrome/browser/tab/SadTabView.java [modify] https://crrev.com/91d3ee3c63734399ce574d0ed71f4004fb7e8605/chrome/android/java/src/org/chromium/chrome/browser/tab/SadTabViewFactory.java [modify] https://crrev.com/91d3ee3c63734399ce574d0ed71f4004fb7e8605/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java [modify] https://crrev.com/91d3ee3c63734399ce574d0ed71f4004fb7e8605/chrome/android/javatests/src/org/chromium/chrome/browser/tab/SadTabTest.java [modify] https://crrev.com/91d3ee3c63734399ce574d0ed71f4004fb7e8605/chrome/browser/ui/sad_tab.cc
,
May 11 2017
|
||||||||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||||||||
Comment 1 by k...@chromium.org
, Apr 4 2017