New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 707346 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

[Payments] Shipping Option select enabled but no effect

Reported by chin.edo...@gmail.com, Mar 31 2017

Issue description

Steps to reproduce the problem:
1. Open the PaymentRequest slate
2. Add a shipping address, the "Checking" spinner is spinning waiting for the server's response, but the "Select" shipping option button is already enabled
3. Click on the "Select" shipping option button while the Shipping address is still spinning

What is the expected behavior?
Clicking on the "Shipping Option" button should open the section

What went wrong?
The click on the shipping options button has no effect

Did this work before? Yes Chrome M56

Chrome version: 57.0.2987.108  Channel: stable
OS Version: OS X 10.12.1
Flash Version: 

Found out the issue while doing some UI automation for PaymentRequest.
Thanks :)
 
Screen Shot 2017-03-31 at 4.04.49 PM.png
69.9 KB View Download
Components: -UI Blink>Payments
Owner: rouslan@chromium.org
Status: Assigned (was: Unconfirmed)
Cc: rouslan@chromium.org
Components: -Blink>Payments UI>Browser>Autofill>Payments
Labels: -Pri-2 -Type-Bug-Regression Pri-3 Type-Bug
Owner: gogerald@chromium.org
I've seen this behavior and agree it's subpar. Assigning to the Android UI owner/expert.
Not sure the expected behavior is the real expected behavior. IIUC, the shipping options might get updated after choosing a different shipping address. So the expected behavior might be grey out the 'Select' button? WDYT?
You're correct, Ganggui. It would be better to gray out the SELECT button "Shipping options" section until The "Shipping address" section stops loading.
Components: -UI>Browser>Autofill>Payments UI>Browser>Payments

Comment 6 Deleted

Cc: ma...@chromium.org zkoch@chromium.org
Looks a little bit nicer to me,

https://drive.google.com/file/d/0B4yF5XJG4VQAMGF1enZReC1VSzA/view?usp=sharing
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/21c46cbe60a09379bf799dbf2ddbbafc14372080

commit 21c46cbe60a09379bf799dbf2ddbbafc14372080
Author: gogerald <gogerald@google.com>
Date: Mon Jul 10 21:26:19 2017

[Payments] Disable edit buttons when the client is checking a selection

Test video:
https://drive.google.com/file/d/0B4yF5XJG4VQAMGF1enZReC1VSzA/view?usp=sharing

Bug:  707346 
Change-Id: I2b503ab789e736e9f6da5646be9e339a9ccb8c61
Reviewed-on: https://chromium-review.googlesource.com/565030
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Commit-Queue: Ganggui Tang <gogerald@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485398}
[modify] https://crrev.com/21c46cbe60a09379bf799dbf2ddbbafc14372080/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java

Status: Fixed (was: Assigned)

Sign in to add a comment