Issue 707342 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	a...@chromium.org
Closed:	Apr 2017
Components:	Tests
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	3
Type:	Bug

Any test waiting for a beforeunload dialog without disabling the beforeunload timer is flaky

Project Member Reported by a...@chromium.org, Mar 31 2017

Issue description

In  bug 705306 , a test went flaky because it was waiting for the wrong timer while trying to show a beforeunload dialog. In fixing it, I found that lots of other tests don't bother to disable the timer, and end up flaky.

I'm going to fix the test code to make sure this can't happen.

Project Member

Comment 1 by bugdroid1@chromium.org, Apr 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3c70a0d266c02d7e91fc5a2e5649247367a8fecc

commit 3c70a0d266c02d7e91fc5a2e5649247367a8fecc
Author: avi <avi@chromium.org>
Date: Thu Apr 06 00:31:42 2017

Fix races in tests waiting for beforeunload dialogs.

BUG= 707342 ,  130411 
TEST=no flakes
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2787393003
Cr-Commit-Position: refs/heads/master@{#462293}

[modify] https://crrev.com/3c70a0d266c02d7e91fc5a2e5649247367a8fecc/chrome/browser/ui/browser_browsertest.cc
[modify] https://crrev.com/3c70a0d266c02d7e91fc5a2e5649247367a8fecc/chrome/browser/unload_browsertest.cc
[modify] https://crrev.com/3c70a0d266c02d7e91fc5a2e5649247367a8fecc/chrome/test/base/ui_test_utils.cc
[modify] https://crrev.com/3c70a0d266c02d7e91fc5a2e5649247367a8fecc/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/3c70a0d266c02d7e91fc5a2e5649247367a8fecc/content/browser/frame_host/render_frame_host_impl.h
[modify] https://crrev.com/3c70a0d266c02d7e91fc5a2e5649247367a8fecc/content/public/browser/render_frame_host.h

Comment 2 by a...@chromium.org, Apr 6 2017

Status: Fixed (was: Started)

►

Issue 707342 link

Issue metadata

Any test waiting for a beforeunload dialog without disabling the beforeunload timer is flaky

Issue description

Comment 1 by bugdroid1@chromium.org, Apr 6 2017

Comment 1 Deleted

Comment 2 by a...@chromium.org, Apr 6 2017

Comment 2 Deleted

Sign in to add a comment