The BluetoothScanFilterInit dictionary seems to match with BluetoothLEScanFilterInit in the spec https://www.google.com/url?q=https://webbluetoothcg.github.io/web-bluetooth/%23dictdef-bluetoothlescanfilterinit, should we rename it to match the spec?
The BluetoothScanFilterInit dictionary seems to match with BluetoothLEScanFilterInit in the spec https://webbluetoothcg.github.io/web-bluetooth/#dictdef-bluetoothlescanfilterinit, should we rename it to match the spec?
Good catch. Feel free to send a CL :)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/321635e96b5f334eb95e09898d923f3f9cedf7fb commit 321635e96b5f334eb95e09898d923f3f9cedf7fb Author: lunalu <lunalu@chromium.org> Date: Wed Apr 05 16:40:49 2017 Rename BluetoothScanFilterInit to BluetoothLEScanFilterInit Rename to match the spec https://webbluetoothcg.github.io/web-bluetooth/#dictdef-bluetoothlescanfilterinit BUG= 707341 Review-Url: https://codereview.chromium.org/2789243002 Cr-Commit-Position: refs/heads/master@{#462111} [modify] https://crrev.com/321635e96b5f334eb95e09898d923f3f9cedf7fb/content/browser/bluetooth/bluetooth_allowed_devices_unittest.cc [modify] https://crrev.com/321635e96b5f334eb95e09898d923f3f9cedf7fb/content/browser/bluetooth/bluetooth_blocklist.cc [modify] https://crrev.com/321635e96b5f334eb95e09898d923f3f9cedf7fb/content/browser/bluetooth/bluetooth_blocklist.h [modify] https://crrev.com/321635e96b5f334eb95e09898d923f3f9cedf7fb/content/browser/bluetooth/bluetooth_blocklist_unittest.cc [modify] https://crrev.com/321635e96b5f334eb95e09898d923f3f9cedf7fb/content/browser/bluetooth/bluetooth_device_chooser_controller.cc [modify] https://crrev.com/321635e96b5f334eb95e09898d923f3f9cedf7fb/content/browser/bluetooth/bluetooth_metrics.cc [modify] https://crrev.com/321635e96b5f334eb95e09898d923f3f9cedf7fb/third_party/WebKit/Source/modules/bluetooth/Bluetooth.cpp [rename] https://crrev.com/321635e96b5f334eb95e09898d923f3f9cedf7fb/third_party/WebKit/Source/modules/bluetooth/BluetoothLEScanFilterInit.idl [modify] https://crrev.com/321635e96b5f334eb95e09898d923f3f9cedf7fb/third_party/WebKit/Source/modules/bluetooth/RequestDeviceOptions.idl [modify] https://crrev.com/321635e96b5f334eb95e09898d923f3f9cedf7fb/third_party/WebKit/Source/modules/modules_idl_files.gni [modify] https://crrev.com/321635e96b5f334eb95e09898d923f3f9cedf7fb/third_party/WebKit/public/platform/modules/bluetooth/web_bluetooth.mojom
Comment 1 by ortuno@chromium.org
, Apr 2 2017Labels: OS-Android OS-Chrome OS-Linux OS-Mac OS-Windows
Status: Available (was: Untriaged)