New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 707332 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

determine pre-cq boards to test for a board-overlays CL based on the files or directories that were touched

Project Member Reported by akes...@chromium.org, Mar 31 2017

Issue description

Example CL https://chromium-review.googlesource.com/#/c/461337/

(determine pre-cq configs programatically instead of relying on CQ ini files for this repo and maybe a few others (like private overlays))
 
Cc: akes...@chromium.org vapier@chromium.org
 Issue 703840  has been merged into this issue.
Another candidate repo: REPO/src/overlays

Comment 3 by aut...@google.com, Apr 4 2017

Labels: -current-issue
Search terms: COMMIT-QUEUE.ini overlay overlays board-overlays
Project Member

Comment 6 by bugdroid1@chromium.org, May 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/843a5325311eefeccb107b0a4d1a5b772d4d5a69

commit 843a5325311eefeccb107b0a4d1a5b772d4d5a69
Author: Ningning Xia <nxia@chromium.org>
Date: Fri May 19 20:57:49 2017

Refactor: Create CQConfigParser to parse options for CQ configs.

Move logics of getting and parsing options of CQ config files to
lib/cq_config.

BUG= chromium:707332 
TEST=unit_tests

Change-Id: I903610e37a354ccf620b2ad00e19de8bac29bf26
Reviewed-on: https://chromium-review.googlesource.com/502547
Commit-Ready: Ningning Xia <nxia@chromium.org>
Tested-by: Ningning Xia <nxia@chromium.org>
Reviewed-by: Ningning Xia <nxia@chromium.org>

[modify] https://crrev.com/843a5325311eefeccb107b0a4d1a5b772d4d5a69/lib/triage_lib_unittest.py
[modify] https://crrev.com/843a5325311eefeccb107b0a4d1a5b772d4d5a69/cbuildbot/relevant_changes.py
[modify] https://crrev.com/843a5325311eefeccb107b0a4d1a5b772d4d5a69/cbuildbot/stages/report_stages_unittest.py
[add] https://crrev.com/843a5325311eefeccb107b0a4d1a5b772d4d5a69/lib/cq_config.py
[add] https://crrev.com/843a5325311eefeccb107b0a4d1a5b772d4d5a69/lib/cq_config_unittest
[modify] https://crrev.com/843a5325311eefeccb107b0a4d1a5b772d4d5a69/cbuildbot/stages/sync_stages_unittest.py
[add] https://crrev.com/843a5325311eefeccb107b0a4d1a5b772d4d5a69/lib/cq_config_unittest.py
[modify] https://crrev.com/843a5325311eefeccb107b0a4d1a5b772d4d5a69/cbuildbot/stages/sync_stages.py
[modify] https://crrev.com/843a5325311eefeccb107b0a4d1a5b772d4d5a69/lib/constants.py
[modify] https://crrev.com/843a5325311eefeccb107b0a4d1a5b772d4d5a69/lib/patch_unittest.py
[modify] https://crrev.com/843a5325311eefeccb107b0a4d1a5b772d4d5a69/lib/triage_lib.py

Project Member

Comment 7 by bugdroid1@chromium.org, May 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/2359e2aa5fd6a4f905cb2238ebe7f68ae1c6f9e3

commit 2359e2aa5fd6a4f905cb2238ebe7f68ae1c6f9e3
Author: Ningning Xia <nxia@chromium.org>
Date: Mon May 29 05:39:14 2017

Get unioned pre cq configs for multi-overlay CLs

Determine the right Pre-CQ target set for CLs touching different
sub-directories when the sub-directories contain different
COMMIT-QUEUE.ini config files. More context: go/union-of-pre-cq-configs

BUG= chromium:707332 
TEST=unit_test

Change-Id: Idc451166dc2572b597b666e0175bb3d79e090255
Reviewed-on: https://chromium-review.googlesource.com/503435
Commit-Ready: Ningning Xia <nxia@chromium.org>
Tested-by: Ningning Xia <nxia@chromium.org>
Reviewed-by: Ningning Xia <nxia@chromium.org>

[modify] https://crrev.com/2359e2aa5fd6a4f905cb2238ebe7f68ae1c6f9e3/lib/cq_config.py
[modify] https://crrev.com/2359e2aa5fd6a4f905cb2238ebe7f68ae1c6f9e3/lib/cq_config_unittest.py
[modify] https://crrev.com/2359e2aa5fd6a4f905cb2238ebe7f68ae1c6f9e3/lib/constants.py
[modify] https://crrev.com/2359e2aa5fd6a4f905cb2238ebe7f68ae1c6f9e3/cbuildbot/stages/sync_stages_unittest.py
[modify] https://crrev.com/2359e2aa5fd6a4f905cb2238ebe7f68ae1c6f9e3/cbuildbot/stages/sync_stages.py

Comment 8 by nxia@chromium.org, Jun 22 2017

Status: Fixed (was: Untriaged)

Comment 9 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment