New issue
Advanced search Search tips

Issue 707331 link

Starred by 1 user
Status: Assigned
Owner:
scottmg@chromium.org
Cc:
jochen@chromium.org
dpranke@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

build/win/BUILD.gn is referenced from all platforms

Project Member Reported by scottmg@chromium.org, Mar 31 2017 
It should probably have an assert(is_win) at the top of it instead, esp. now that it's doing more stuff than just the manifest after https://codereview.chromium.org/2782603002/ .

Comment 1 by scottmg@chromium.org, Mar 31 2017 

Hmm, there are kind of a lot of them https://cs.chromium.org/search/?q=default_exe_manifest+package:%5Echromium$ . Maybe it's tidier to not put each "callsite" in an if block. I wonder what the precedent is like either way...
►

Sign in to add a comment