New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 707326 link

Starred by 2 users
Status: Fixed
Owner:
taku...@chromium.org
Closed: Jul 2017
Cc:
█ imch...@chromium.org
taku...@chromium.org
mfo...@chromium.org
btolsch@chromium.org
powerb@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

[Media Router] Define UMA metrics for migrated custom controller templates

Project Member Reported by imch...@chromium.org, Mar 31 2017 
To measure the performance of the migrated custom controller templates, we should record the following metrics (list not exhaustive):

- time to render the route details view. We should try to record it in such a way that it can be compared against extensionview-based templates.
- success / failure of creating the route controller + status observer
- controller closed by user vs error. It might be worthwhile to break down by mojo error code as well.

Comment 1 by taku...@chromium.org, May 17 2017

Owner: taku...@chromium.org
Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8acf7ed04acf24171f8928a26329a731955470e9

commit 8acf7ed04acf24171f8928a26329a731955470e9
Author: takumif <takumif@chromium.org>
Date: Tue Jun 06 18:24:03 2017

[Media Router] Add UMA metrics to record the load time for route controls

This CL adds a metric to measure how long it takes the WebUI route controls to
load after the route details view was opened. We also send the timestamp for
when the view was opened to the extensionview, so that we can also measure the
load time of the extensionview (done on the extension-side [1]).

[1] cl/157656839

BUG= 707326 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2915983002
Cr-Commit-Position: refs/heads/master@{#477343}

[modify] https://crrev.com/8acf7ed04acf24171f8928a26329a731955470e9/chrome/browser/resources/media_router/elements/route_controls/route_controls.js
[modify] https://crrev.com/8acf7ed04acf24171f8928a26329a731955470e9/chrome/browser/resources/media_router/elements/route_details/extension_view_wrapper/extension_view_wrapper.js
[modify] https://crrev.com/8acf7ed04acf24171f8928a26329a731955470e9/chrome/browser/resources/media_router/elements/route_details/route_details.html
[modify] https://crrev.com/8acf7ed04acf24171f8928a26329a731955470e9/chrome/browser/resources/media_router/elements/route_details/route_details.js
[modify] https://crrev.com/8acf7ed04acf24171f8928a26329a731955470e9/chrome/browser/resources/media_router/media_router_browser_api.js
[modify] https://crrev.com/8acf7ed04acf24171f8928a26329a731955470e9/chrome/browser/ui/webui/media_router/media_router_webui_message_handler.cc
[modify] https://crrev.com/8acf7ed04acf24171f8928a26329a731955470e9/chrome/browser/ui/webui/media_router/media_router_webui_message_handler.h
[modify] https://crrev.com/8acf7ed04acf24171f8928a26329a731955470e9/chrome/test/data/webui/media_router/route_details_tests.js
[modify] https://crrev.com/8acf7ed04acf24171f8928a26329a731955470e9/tools/metrics/histograms/histograms.xml

Comment 3 by taku...@chromium.org, Jul 19 2017

Labels: -Type-Bug Type-Task
Status: Fixed (was: Started)
►

Sign in to add a comment