New issue
Advanced search Search tips

Issue 707311 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

cros-disks: remove deprecated archive type entries in archive manager

Project Member Reported by benchan@chromium.org, Mar 31 2017

Issue description

Remove deprecated archive type entries in cros-disks archive manager.
 

Comment 1 by vapier@chromium.org, Mar 31 2017

Components: Platform>Apps>FileManager
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/84e4d7433beb8c75d0a3abf8ed64f0d7feb17196

commit 84e4d7433beb8c75d0a3abf8ed64f0d7feb17196
Author: Ben Chan <benchan@chromium.org>
Date: Sat Apr 01 08:35:56 2017

autotest-tests: remove platform_CrosDisksArchive test

The platform_CrosDisksArchive test is being removed as the support for
zip, tar, and gzip/bzip2 compressed tar archives in cros-disks has been
replaced by extension using the chrome.fileSystemProvider API.

BUG= chromium:707311 
CQ-DEPEND=CL:465507
TEST=Remote trybot builds.

Change-Id: I462daca2afbd00568c194ac717c205928b6617b8
Reviewed-on: https://chromium-review.googlesource.com/465448
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Ben Chan <benchan@chromium.org>

[modify] https://crrev.com/84e4d7433beb8c75d0a3abf8ed64f0d7feb17196/chromeos-base/autotest-tests-cros-disks/autotest-tests-cros-disks-9999.ebuild

Project Member

Comment 3 by bugdroid1@chromium.org, Apr 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/38b7871f8af661df4c1dd6c78f274dd4d1eb58d6

commit 38b7871f8af661df4c1dd6c78f274dd4d1eb58d6
Author: Ben Chan <benchan@chromium.org>
Date: Sat Apr 01 08:35:56 2017

Remove platform_CrosDisksArchive test.

Support for zip, tar, and gzip/bzip2 compressed tar archives in
cros-disks has been replaced by extensions using the
chrome.fileSystemProvider API. This CL removes the
platform_CrosDisksArchive test.

BUG= chromium:707311 
CQ-DEPEND=CL:465448
TEST=Remote trybot builds.

Change-Id: I7e9efc9f54fd4d68ca5405b432f3eb3f25ccbec3
Reviewed-on: https://chromium-review.googlesource.com/465507
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[delete] https://crrev.com/e75ed007b1e5eef5e85942f5db9fd8c447d04279/client/site_tests/platform_CrosDisksArchive/control
[delete] https://crrev.com/e75ed007b1e5eef5e85942f5db9fd8c447d04279/client/site_tests/platform_CrosDisksArchive/platform_CrosDisksArchive.py

Project Member

Comment 4 by bugdroid1@chromium.org, Apr 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/210f193b1700cf8fba8a3285030959fdd81b4216

commit 210f193b1700cf8fba8a3285030959fdd81b4216
Author: Ben Chan <benchan@chromium.org>
Date: Sat Apr 01 08:35:56 2017

cros-disks: remove deprecated archive types from archive manager

Support for zip, tar, and gzip/bzip2 compressed tar has been deprecated
for quite some time in favor of extensions using the
chrome.fileSystemProvider API. This CL removes the support for these
deprecated archive types completely from archive manager.

BUG= chromium:707311 
CQ-DEPEND=CL:465448
CQ-DEPEND=CL:465507
TEST=Run unit tests.

Change-Id: I08a6536d26bcd02cd4a9b3f78835d1026143696f
Reviewed-on: https://chromium-review.googlesource.com/465369
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/210f193b1700cf8fba8a3285030959fdd81b4216/cros-disks/archive_manager.cc

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)

Sign in to add a comment