Omnibox randomly disappears and appears |
|||||||
Issue descriptionApp Version (from "Chrome Settings > About Chrome"): 59.0.3057.0 canary iOS Version: 10.3.2b1 Device: 6S Steps to reproduce: 1. Load the webpage: https://ghibliapi.herokuapp.com/#section/Studio-Ghibli-API 2. Scroll up and down Observed behavior: Omnibox disappears and appears both going up and down the page. Expected behavior: Omnibox should not disappear and reappear. Frequency: 5/5 <number of times you were able to reproduce> Additional comments: Video here: https://drive.google.com/open?id=0B3dPCXKQYa2dUlRZbExHZTlwcms I didn't tap the omnibox at all. I just scrolled up and down the page.
,
Apr 3 2017
,
Apr 3 2017
Looks like the page constantly changes URL fragment. WebStateObserver allows distinguishing between same document navigations and real navigation.
,
Apr 12 2017
,
Apr 12 2017
From offline conversations with michaeldo, it seems that this is occurring because the page is continuously calling window.location.replace() to set the current URL. Because WKWebView's window.location.replace() is non-overridable, we are counting each of these as a new navigation and A) showing the toolbar via the fullscreen controller, and B) adding a bunch of NavigationItems to our history.
,
Apr 12 2017
How do we handle window.location.replace in WebController? I thought it happens in |URLDidChangeWithoutDocumentChange|, which sends SamePage navigation callback and Tab could ignore it by checking NavigationContext::IsSamePage() flag.
,
Aug 17
Please retest. Can't repro anymore.
,
Aug 20
Tested on 69.0.3497.50 Beta, iPhone X iOS 11.4.1, iPhone 7 iOS 12.0beta8 issue is not repro. |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by edchin@chromium.org
, Apr 3 2017Labels: M-59
Owner: michaeldo@chromium.org
Status: Assigned (was: Untriaged)