Icon and text in password promo has shifted to the left |
||||||
Issue descriptionhttps://drive.google.com/open?id=0B3dPCXKQYa2dblduaW9UYi1ESm8 Canary 59.0.3057.0 The title should be aligned with the body text.
,
Mar 31 2017
Bug is also present in latest Dev build (59.0.3053.3)
,
Mar 31 2017
Please see the image in issue 707290 for what it should look like (right side of image).
,
Apr 3 2017
The issue does not exist in 58.0.3029.39 and exists in 58.0.3029.40.
,
Apr 3 2017
I think this CL is the root cause: https://chromium.googlesource.com/chromium/src.git/+/623dc2bca68212e0f7e4617e84585a74fe63c7bc That's the only change in c/b/ui/views between v39 and v40.
,
Apr 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9d291fab2615e3fcefba25e352dfab6e4fb0355f commit 9d291fab2615e3fcefba25e352dfab6e4fb0355f Author: mrefaat <mrefaat@chromium.org> Date: Thu Apr 06 18:47:18 2017 Fix body alignment for the desktop iOS promotion Bubble. This got broken by https://chromium.googlesource.com/chromium/src.git/+/623dc2bca68212e0f7e4617e84585a74fe63c7bc which was merged to m58 BUG= 707289 Review-Url: https://codereview.chromium.org/2800723003 Cr-Commit-Position: refs/heads/master@{#462560} [modify] https://crrev.com/9d291fab2615e3fcefba25e352dfab6e4fb0355f/chrome/browser/ui/views/desktop_ios_promotion/desktop_ios_promotion_bubble_view.cc
,
Apr 7 2017
,
Apr 7 2017
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 7 2017
Your change is approved for M58. Please verify the fix, if all looks good merge ASAP so that it will be picked up for next Beta Release.
,
Apr 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e5057f1b8dc1fb10ba2d1af993e4ac59c7587bc0 commit e5057f1b8dc1fb10ba2d1af993e4ac59c7587bc0 Author: mrefaat <mrefaat@chromium.org> Date: Mon Apr 10 17:43:12 2017 [Merge to 58]Fix body alignment for the desktop iOS promotion Bubble. This got broken by https://chromium.googlesource.com/chromium/src.git/+/623dc2bca68212e0f7e4617e84585a74fe63c7bc which was merged to m58 BUG= 707289 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2800723003 Cr-Commit-Position: refs/heads/master@{#462560} (cherry picked from commit 9d291fab2615e3fcefba25e352dfab6e4fb0355f) Review-Url: https://codereview.chromium.org/2807183002 Cr-Commit-Position: refs/branch-heads/3029@{#646} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} [modify] https://crrev.com/e5057f1b8dc1fb10ba2d1af993e4ac59c7587bc0/chrome/browser/ui/views/desktop_ios_promotion/desktop_ios_promotion_bubble_view.cc
,
Apr 12 2017
Tested the issue on windows 7 using chrome version 58.0.3029.68 with the below steps 1.Login to Gmail 2.Observed the title and text are aligned properly on Password sign in promo. Please find the attached screen shot for the same. But observed the same behaviour on reported version 59.0.3057.0 also. mrefaat@ could you please confirm if anything missed here in verifying the issue. Thanks,
,
Apr 12 2017
We have manually verified that this issue is fixed (it is not the bubble in #11). The root cause of this issue is issue 711012 . |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by jasonkliu@chromium.org
, Mar 31 2017