New issue
Advanced search Search tips

Issue 707278 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug
Proj-XR



Sign in to add a comment

Strictmode violation crash when initializing non-presenting GVR api

Project Member Reported by mthiesse@chromium.org, Mar 31 2017

Issue description

In rare cases initializing the non-presenting GVR Layout can cause strictmode violations by causing Daydream to create its settings file.


Crash ID: 44ff367810000000
 
Labels: Merge-Request-58
Project Member

Comment 3 by sheriffbot@chromium.org, Apr 3 2017

Labels: -Merge-Request-58 Hotlist-Merge-Approved Merge-Approved-58
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 3 2017

Labels: -merge-approved-58 merge-merged-3029
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa06f379a8f522af6c94e551139fd2127ac78c7c

commit fa06f379a8f522af6c94e551139fd2127ac78c7c
Author: Michael Thiessen <mthiesse@chromium.org>
Date: Mon Apr 03 14:34:00 2017

Fix possible Strictmode crash when initializing non-presenting GVR context.

BUG= 707278 

Review-Url: https://codereview.chromium.org/2788183002
Cr-Commit-Position: refs/heads/master@{#461198}
(cherry picked from commit 09533657d232cd63351a1bceb6afbb507e414efc)

Review-Url: https://codereview.chromium.org/2790153002 .
Cr-Commit-Position: refs/branch-heads/3029@{#543}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/fa06f379a8f522af6c94e551139fd2127ac78c7c/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/NonPresentingGvrContextImpl.java
[modify] https://crrev.com/fa06f379a8f522af6c94e551139fd2127ac78c7c/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java

Status: Fixed (was: Started)
Labels: Proj-VR
Components: Blink>WebXR

Sign in to add a comment