New issue
Advanced search Search tips

Issue 707275 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug
Proj-XR
Proj-XR-VR



Sign in to add a comment

Entering VrShell results in black screen in automated tests

Project Member Reported by bsheedy@chromium.org, Mar 31 2017

Issue description

I am able to manually enter VR Shell via an NFC tag scan just fine. However, entering VR Shell in end-to-end tests results in a black screen (no content, background, or pointer), although the overlay is still present.

Reproducible by adding the following "test" case to VrShellTest.java:

@LargeTest
public void testBlackScreen() {
  VrUtils.forceEnterVr();
  SystemClock.sleep(20000);
}

Using VrUtils.simNfc(getActivity()) instead of forceEnterVr() also reproduces.

GN args (same as the FYI bot is using):
is_component_build=false is_debug=true proprietary_codecs=true strip_absolute_paths_from_debug_symbols=true symbol_level=1 target_os="android" use_goma=true ffmpeg_branding="Chrome"

Interestingly, if you remove the forceEnterVr() (so all the test does is sleep) and instead manually scan an actual NFC tag during the test, the issue still occurs, so it looks like the instrumentation tests being present might somehow be affecting the behavior of Chrome/VR Shell.
 
Still happening on ToT as of today.
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/53f787b5b82c2e4d3967bc09a803faae7ea42350

commit 53f787b5b82c2e4d3967bc09a803faae7ea42350
Author: bsheedy <bsheedy@chromium.org>
Date: Tue Apr 25 14:49:19 2017

Fix VR Shell black screen during tests

Forces VrShellDelegate's constructor to run on the main/UI thread, as
otherwise the Choreographer instance acquired in the constructor is for
the instrumentation thread during e2e tests, which breaks VR Shell.

BUG= 707275 

Review-Url: https://codereview.chromium.org/2838763002
Cr-Commit-Position: refs/heads/master@{#466990}

[modify] https://crrev.com/53f787b5b82c2e4d3967bc09a803faae7ea42350/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java
[modify] https://crrev.com/53f787b5b82c2e4d3967bc09a803faae7ea42350/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrShellTest.java

Status: Fixed (was: Untriaged)
Labels: VR-Caught-By-Test
Labels: Test-Complete
Labels: -VR-Caught-By-Test XR-Caught-By-Test

Sign in to add a comment