New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 707272 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

rename DISABLE_LOFI_MODE to DISABLE_PREVIEWS

Project Member Reported by ryansturm@chromium.org, Mar 31 2017

Issue description

content::ReloadType::DISABLE_LOFI_MODE disables various previews (and should disable all previews outside of general reload logic). This should be renamed DISABLE_PREVIEWS.
 
Does this block Issue 745942?
No. If AMP uses the GetPreviewsState method, it should respect DISABLE_LOFI_MODE already.
Owner: thanhdle@chromium.org
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/006f2532ea48d3f3185baf7c800633aabfccfb96

commit 006f2532ea48d3f3185baf7c800633aabfccfb96
Author: Thanh Le <thanhdle@chromium.org>
Date: Wed Sep 13 17:38:04 2017

Change the enum name of DISABLE_LOFI_MODE to DISABLE_PREVIEWS since it disables all previews outside of general reload topic.

Bug:  707272 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Change-Id: Ied478af0c8322a7d48494d5614695b4ef7c368d2
Reviewed-on: https://chromium-review.googlesource.com/663822
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Thanh Le <thanhdle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501680}
[modify] https://crrev.com/006f2532ea48d3f3185baf7c800633aabfccfb96/chrome/browser/previews/previews_infobar_delegate.cc
[modify] https://crrev.com/006f2532ea48d3f3185baf7c800633aabfccfb96/chrome/browser/previews/previews_infobar_delegate_unittest.cc
[modify] https://crrev.com/006f2532ea48d3f3185baf7c800633aabfccfb96/content/browser/frame_host/navigator_impl.cc
[modify] https://crrev.com/006f2532ea48d3f3185baf7c800633aabfccfb96/content/browser/loader/resource_dispatcher_host_browsertest.cc
[modify] https://crrev.com/006f2532ea48d3f3185baf7c800633aabfccfb96/content/public/browser/reload_type.h

Cc: ryansturm@chromium.org
Status: Fixed (was: Assigned)

Comment 6 by efoo@chromium.org, Dec 5 2017

Components: Blink>Previews

Comment 7 by efoo@chromium.org, Dec 5 2017

Components: -UI>Browser>Previews

Sign in to add a comment