New issue
Advanced search Search tips

Issue 707264 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Closed: Sep 2017
Cc:
EstimatedDays: ----
NextAction: 2017-11-10
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Feature
Launch-M-Target: 64-Beta


Show other hotlists

Hotlists containing this issue:
Hotlist-1


Sign in to add a comment

Ensure dialogs have close X iff they are popovers, no redundant cancel buttons

Project Member Reported by hwi@chromium.org, Mar 31 2017

Issue description

Please update the Harmony *popover* dialog template to include X. 

UI Review (2017 Feb 28): go/crhcxur

Popover dialogs (previously anchored dialogs/infobubbles): 

Spec: 
- Close X on all desktop platforms
- No Cancel button if it’s redundant (Note: removing the existing cancel buttons should be scoped for post V1)

Rationale:
- Optional offering: Popover contents in Chrome are typically optional offerings initiated by Chrome features. The user should be able to dismiss them quickly when not interested, without needing to read the content. 
- Visible cue: Clicking-out is a nice hidden dismissal gesture to continue to keep, however, that should not be the default way since it’s not immediately discoverable and also, notably, clicking-out often triggers to open an ad. A visual element is a more reliable way to dismiss a popover.

Note: Harmony *modal* dialogs have *no* X, and do have a labeled button ( bug 707263 ).

Thanks!
 
Description: Show this description
Cc: -ellyjo...@chromium.org bsep@chromium.org
Owner: hwi@chromium.org
Status: Assigned (was: Untriaged)
Summary: Ensure all popover dialogs have close X, no redundant cancel buttons (was: Keep Close X on Harmony popover dialogs on all desktop platforms)
Most of the work here will happen when converting individual dialogs.  Once they are converted, we should audit all dialogs marked "popover" in the spreadsheet to ensure they comply.  This should be done before we ship phase 1 and is the primary thing this bug covers.  Assigning this to hwi to ensure this either gets verified per-dialog or as an audit pass.

Secondarily: Longer-term, Bret and I have talked some about collapsing the various dialog overrides we have today (e.g. ShouldShowCloseButton()) into some single enum that controls modality, close button presence, draggability (although it now sounds like that's likely so be set "false" for all dialogs), and any other associated factors all at once.  This will hopefully make it easier to just say "this is a popover" and get all the right behaviors.  Hopefully by the time we finish the above audit we'll have enough context to decide what, if anything, should happen here.  Actually doing something is post-phase 1 and maybe will be split into another bug.  CCing Bret in case he has thoughts here.
Summary: Ensure dialogs have close X iff they are popovers, no redundant cancel buttons (was: Ensure all popover dialogs have close X, no redundant cancel buttons)
Widening to also cover ensuring modal dialogs have no close X.
Cc: ellyjo...@chromium.org
 Issue 707263  has been merged into this issue.
Labels: Launch-M-Target-64-Beta
NextAction: 2017-11-10
Status: WontFix (was: Assigned)
This should be done on per dialogue basis. Closing this bug. 
The NextAction date has arrived: 2017-11-10

Sign in to add a comment