Ensure dialogs have close X iff they are popovers, no redundant cancel buttons |
||||||
Issue descriptionPlease update the Harmony *popover* dialog template to include X. UI Review (2017 Feb 28): go/crhcxur Popover dialogs (previously anchored dialogs/infobubbles): Spec: - Close X on all desktop platforms - No Cancel button if it’s redundant (Note: removing the existing cancel buttons should be scoped for post V1) Rationale: - Optional offering: Popover contents in Chrome are typically optional offerings initiated by Chrome features. The user should be able to dismiss them quickly when not interested, without needing to read the content. - Visible cue: Clicking-out is a nice hidden dismissal gesture to continue to keep, however, that should not be the default way since it’s not immediately discoverable and also, notably, clicking-out often triggers to open an ad. A visual element is a more reliable way to dismiss a popover. Note: Harmony *modal* dialogs have *no* X, and do have a labeled button ( bug 707263 ). Thanks!
,
Aug 2 2017
Most of the work here will happen when converting individual dialogs. Once they are converted, we should audit all dialogs marked "popover" in the spreadsheet to ensure they comply. This should be done before we ship phase 1 and is the primary thing this bug covers. Assigning this to hwi to ensure this either gets verified per-dialog or as an audit pass. Secondarily: Longer-term, Bret and I have talked some about collapsing the various dialog overrides we have today (e.g. ShouldShowCloseButton()) into some single enum that controls modality, close button presence, draggability (although it now sounds like that's likely so be set "false" for all dialogs), and any other associated factors all at once. This will hopefully make it easier to just say "this is a popover" and get all the right behaviors. Hopefully by the time we finish the above audit we'll have enough context to decide what, if anything, should happen here. Actually doing something is post-phase 1 and maybe will be split into another bug. CCing Bret in case he has thoughts here.
,
Aug 2 2017
Widening to also cover ensuring modal dialogs have no close X.
,
Aug 2 2017
,
Sep 5 2017
,
Sep 5 2017
,
Sep 20 2017
This should be done on per dialogue basis. Closing this bug.
,
Nov 10 2017
The NextAction date has arrived: 2017-11-10 |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by pkasting@chromium.org
, Apr 13 2017