New issue
Advanced search Search tips

Issue 707262 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

remove MediaSettingsRange.current

Project Member Reported by mcasas@chromium.org, Mar 31 2017

Issue description

Not in the Spec, and should not be needed
(https://github.com/w3c/mediacapture-image/issues/106)
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a1052a48bc85cc5d68c0f7dc0782b577e92cc9c7

commit a1052a48bc85cc5d68c0f7dc0782b577e92cc9c7
Author: mcasas <mcasas@chromium.org>
Date: Wed Apr 05 04:08:44 2017

Image Capture: remove MediaSettingsRange.current

This CL removes MediaSettingsRange.current member, which
was never in the Spec to start with. "Current" feature values
still need to be kept around for getMediaTrackSettings(): with
the |current| member gone, we aneed to dd a new member
|m_settings| to keep them (and it encompasses the previous
points of interest vector).

LayoutTests updated accordingly.

BUG= 700607 ,  707262 

Review-Url: https://codereview.chromium.org/2795923003
Cr-Commit-Position: refs/heads/master@{#461974}

[modify] https://crrev.com/a1052a48bc85cc5d68c0f7dc0782b577e92cc9c7/third_party/WebKit/LayoutTests/imagecapture/MediaStreamTrack-applyConstraints-getSettings.html
[modify] https://crrev.com/a1052a48bc85cc5d68c0f7dc0782b577e92cc9c7/third_party/WebKit/LayoutTests/imagecapture/MediaStreamTrack-getCapabilities.html
[modify] https://crrev.com/a1052a48bc85cc5d68c0f7dc0782b577e92cc9c7/third_party/WebKit/LayoutTests/imagecapture/MediaStreamTrack-getSettings.html
[modify] https://crrev.com/a1052a48bc85cc5d68c0f7dc0782b577e92cc9c7/third_party/WebKit/LayoutTests/imagecapture/getphotocapabilities.html
[modify] https://crrev.com/a1052a48bc85cc5d68c0f7dc0782b577e92cc9c7/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/a1052a48bc85cc5d68c0f7dc0782b577e92cc9c7/third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp
[modify] https://crrev.com/a1052a48bc85cc5d68c0f7dc0782b577e92cc9c7/third_party/WebKit/Source/modules/imagecapture/ImageCapture.h
[modify] https://crrev.com/a1052a48bc85cc5d68c0f7dc0782b577e92cc9c7/third_party/WebKit/Source/modules/imagecapture/MediaSettingsRange.h
[modify] https://crrev.com/a1052a48bc85cc5d68c0f7dc0782b577e92cc9c7/third_party/WebKit/Source/modules/imagecapture/MediaSettingsRange.idl

Should this be closed? :)
Cc: mlamouri@chromium.org
Status: Fixed (was: Available)
Yes! Closed.

Sign in to add a comment