New issue
Advanced search Search tips

Issue 707253 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Fix password generation popup width

Project Member Reported by dvadym@chromium.org, Mar 31 2017

Issue description

After recent strings update it turned out that the width of password generation popup calculated incorrectly and a string "Use a strong password..." is elided. A screenshot is attached.
 
Incorrect_gen_popup.png
11.0 KB View Download

Comment 1 by dvadym@chromium.org, Mar 31 2017

A screenshot with a fix in CL https://codereview.chromium.org/2790953002/ is attached.
Fixed_gen_popup.png
10.1 KB View Download
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f49d5b25ff568f099280ac9c285638f86efa7ea8

commit f49d5b25ff568f099280ac9c285638f86efa7ea8
Author: dvadym <dvadym@chromium.org>
Date: Mon Apr 03 13:14:10 2017

Fix calculation of Password Generation popup.

A width of |password_view_| was not taken into consideration for calculation of width of Password Generation popup. Screenshoots how it looks like before and after fixes are on the bug.

This CL introduces, that width of Password Generation popup should be at least width of |password_view_| + borders.

BUG= 707253 

Review-Url: https://codereview.chromium.org/2790953002
Cr-Commit-Position: refs/heads/master@{#461415}

[modify] https://crrev.com/f49d5b25ff568f099280ac9c285638f86efa7ea8/chrome/browser/ui/views/autofill/password_generation_popup_view_views.cc

Status: Fixed (was: Started)

Sign in to add a comment