New issue
Advanced search Search tips

Issue 707240 link

Starred by 1 user
Status: Fixed
Owner:
ma...@chromium.org
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

[Payments] Desktop: Implement shipping address/option change

Project Member Reported by ma...@chromium.org, Mar 31 2017 
When a shipping option element is touched, return to the previous screen and call Mojo's PaymentRequestClient.OnShippingOptionChange(). (Do not make the touched option the selected shipping option. This will happen when Mojo calls back via PaymentRequest.updateWith().)

Comment 1 by ma...@chromium.org, Apr 3 2017

Summary: [Payments] Desktop: Implement shipping address/option change (was: [Payments] Desktop: Implement shipping option change)
Updated title to reflect that this bug will also track implementing shipping _address_ change.
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/151bd31ea040cb745cdc07e59d4b097186ec3ab3

commit 151bd31ea040cb745cdc07e59d4b097186ec3ab3
Author: mathp <mathp@chromium.org>
Date: Mon Apr 03 21:07:24 2017

[Payments] Desktop: implement shipping address/option change

Now when an address/shipping option is selected, the information
goes to the merchant and when updateWith eventually gets called,
the information is updated in the UI.

Moved the selection of the shipping option to the spec, as we merely
forward the selection event to the merchant and recompute from the
PaymentDetails when updateWith is called.

Modified DialogEventObserver so that it can observe a sequence of
events.

BUG= 707240 
TEST=components_unittests, browser_tests

Review-Url: https://codereview.chromium.org/2789093002
Cr-Commit-Position: refs/heads/master@{#461537}

[modify] https://crrev.com/151bd31ea040cb745cdc07e59d4b097186ec3ab3/chrome/browser/ui/views/payments/order_summary_view_controller.cc
[modify] https://crrev.com/151bd31ea040cb745cdc07e59d4b097186ec3ab3/chrome/browser/ui/views/payments/order_summary_view_controller.h
[add] https://crrev.com/151bd31ea040cb745cdc07e59d4b097186ec3ab3/chrome/browser/ui/views/payments/order_summary_view_controller_browsertest.cc
[modify] https://crrev.com/151bd31ea040cb745cdc07e59d4b097186ec3ab3/chrome/browser/ui/views/payments/payment_request_browsertest.cc
[modify] https://crrev.com/151bd31ea040cb745cdc07e59d4b097186ec3ab3/chrome/browser/ui/views/payments/payment_request_browsertest_base.cc
[modify] https://crrev.com/151bd31ea040cb745cdc07e59d4b097186ec3ab3/chrome/browser/ui/views/payments/payment_request_browsertest_base.h
[modify] https://crrev.com/151bd31ea040cb745cdc07e59d4b097186ec3ab3/chrome/browser/ui/views/payments/payment_request_dialog_view.cc
[modify] https://crrev.com/151bd31ea040cb745cdc07e59d4b097186ec3ab3/chrome/browser/ui/views/payments/payment_request_dialog_view.h
[modify] https://crrev.com/151bd31ea040cb745cdc07e59d4b097186ec3ab3/chrome/browser/ui/views/payments/payment_request_dialog_view_ids.h
[modify] https://crrev.com/151bd31ea040cb745cdc07e59d4b097186ec3ab3/chrome/browser/ui/views/payments/payment_request_views_util.cc
[modify] https://crrev.com/151bd31ea040cb745cdc07e59d4b097186ec3ab3/chrome/browser/ui/views/payments/payment_sheet_view_controller.cc
[modify] https://crrev.com/151bd31ea040cb745cdc07e59d4b097186ec3ab3/chrome/browser/ui/views/payments/payment_sheet_view_controller.h
[modify] https://crrev.com/151bd31ea040cb745cdc07e59d4b097186ec3ab3/chrome/browser/ui/views/payments/profile_list_view_controller.cc
[modify] https://crrev.com/151bd31ea040cb745cdc07e59d4b097186ec3ab3/chrome/browser/ui/views/payments/profile_list_view_controller.h
[modify] https://crrev.com/151bd31ea040cb745cdc07e59d4b097186ec3ab3/chrome/browser/ui/views/payments/shipping_option_view_controller.cc
[modify] https://crrev.com/151bd31ea040cb745cdc07e59d4b097186ec3ab3/chrome/test/BUILD.gn
[modify] https://crrev.com/151bd31ea040cb745cdc07e59d4b097186ec3ab3/components/payments/content/payment_request.cc
[modify] https://crrev.com/151bd31ea040cb745cdc07e59d4b097186ec3ab3/components/payments/content/payment_request.h
[modify] https://crrev.com/151bd31ea040cb745cdc07e59d4b097186ec3ab3/components/payments/content/payment_request_spec.cc
[modify] https://crrev.com/151bd31ea040cb745cdc07e59d4b097186ec3ab3/components/payments/content/payment_request_spec.h
[modify] https://crrev.com/151bd31ea040cb745cdc07e59d4b097186ec3ab3/components/payments/content/payment_request_spec_unittest.cc
[modify] https://crrev.com/151bd31ea040cb745cdc07e59d4b097186ec3ab3/components/payments/content/payment_request_state.cc
[modify] https://crrev.com/151bd31ea040cb745cdc07e59d4b097186ec3ab3/components/payments/content/payment_request_state.h
[modify] https://crrev.com/151bd31ea040cb745cdc07e59d4b097186ec3ab3/components/payments/content/payment_request_state_unittest.cc

Comment 3 by ma...@chromium.org, Apr 4 2017

Status: Fixed (was: Started)
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 10 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/281faa09393f7448e894309581d531429abb4fa1

commit 281faa09393f7448e894309581d531429abb4fa1
Author: mathp <mathp@chromium.org>
Date: Mon Apr 10 17:22:19 2017

[Payments] Fix bug in shipping option selection.

The code was not handling a shipping option going away very well.

BUG= 707240 
TEST=browser_tests

Review-Url: https://codereview.chromium.org/2808883002
Cr-Commit-Position: refs/heads/master@{#463306}

[modify] https://crrev.com/281faa09393f7448e894309581d531429abb4fa1/chrome/browser/ui/views/payments/order_summary_view_controller_browsertest.cc
[modify] https://crrev.com/281faa09393f7448e894309581d531429abb4fa1/chrome/browser/ui/views/payments/payment_request_browsertest_base.cc
[modify] https://crrev.com/281faa09393f7448e894309581d531429abb4fa1/chrome/browser/ui/views/payments/payment_request_browsertest_base.h
[modify] https://crrev.com/281faa09393f7448e894309581d531429abb4fa1/chrome/browser/ui/views/payments/payment_request_dialog_view.cc
[modify] https://crrev.com/281faa09393f7448e894309581d531429abb4fa1/chrome/browser/ui/views/payments/payment_request_dialog_view.h
[modify] https://crrev.com/281faa09393f7448e894309581d531429abb4fa1/chrome/browser/ui/views/payments/payment_request_dialog_view_ids.h
[modify] https://crrev.com/281faa09393f7448e894309581d531429abb4fa1/chrome/browser/ui/views/payments/payment_sheet_view_controller.cc
[modify] https://crrev.com/281faa09393f7448e894309581d531429abb4fa1/chrome/browser/ui/views/payments/payment_sheet_view_controller_browsertest.cc
[modify] https://crrev.com/281faa09393f7448e894309581d531429abb4fa1/chrome/browser/ui/views/payments/shipping_option_view_controller.cc
[modify] https://crrev.com/281faa09393f7448e894309581d531429abb4fa1/chrome/browser/ui/views/payments/shipping_option_view_controller.h
[add] https://crrev.com/281faa09393f7448e894309581d531429abb4fa1/chrome/browser/ui/views/payments/shipping_option_view_controller_browsertest.cc
[modify] https://crrev.com/281faa09393f7448e894309581d531429abb4fa1/chrome/test/BUILD.gn
[modify] https://crrev.com/281faa09393f7448e894309581d531429abb4fa1/components/payments/content/payment_request_spec.cc

Comment 5 by lafo...@chromium.org, Jun 27 2017

Components: -UI>Browser>Autofill>Payments UI>Browser>Payments
►

Sign in to add a comment