New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 707237 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 707236
issue 711794
issue 714616
issue 716025



Sign in to add a comment

Remove "@decorators.Disabled('reference')" on perf benchmarks

Project Member Reported by nedngu...@google.com, Mar 31 2017

Issue description

Now that reference build failure are no longer marked as failed ( issue 680138 ), we should remove all the 
@decorators.Disabled('reference')" on perf benchmarks.

This should be blocked on  issue 707236  to make sure that we don't blow up the cycle time of the perf waterfall too much.
 
Blockedon: 711794
Blockedon: 714616
Owner: nedngu...@google.com
Status: Assigned (was: Untriaged)
Blockedon: 716025
Status: Started (was: Assigned)
Cc: rnep...@chromium.org
I will enabling this by phase carefully to avoid us blowing up the waterfall cycle time unexpectedly.
Project Member

Comment 7 by bugdroid1@chromium.org, May 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0af024d53ed6e1ad7759ed5423ef6f98a9c7f6af

commit 0af024d53ed6e1ad7759ed5423ef6f98a9c7f6af
Author: nednguyen <nednguyen@google.com>
Date: Wed May 03 21:08:07 2017

Remove disabling of reference builds on V8 benchmarks

Now that we ignore the return code of reference benchmarks run, there is no need
to disabling these benchmarks on reference build.

BUG= 707237 

Review-Url: https://codereview.chromium.org/2860753002
Cr-Commit-Position: refs/heads/master@{#469120}

[modify] https://crrev.com/0af024d53ed6e1ad7759ed5423ef6f98a9c7f6af/tools/perf/benchmarks/v8_browsing.py

Project Member

Comment 8 by bugdroid1@chromium.org, May 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/39cbe807824bdd083a40d66a9958b1fdfb5a8af8

commit 39cbe807824bdd083a40d66a9958b1fdfb5a8af8
Author: nednguyen <nednguyen@google.com>
Date: Tue May 09 07:46:00 2017

Remove disabling reference logic for blink_perf benchmarks

BUG= 707237 ,  653970 , 576779
TBR=charliea@chromium.org

Review-Url: https://codereview.chromium.org/2864893002
Cr-Commit-Position: refs/heads/master@{#470263}

[modify] https://crrev.com/39cbe807824bdd083a40d66a9958b1fdfb5a8af8/tools/perf/benchmarks/blink_perf.py

Project Member

Comment 9 by sheriffbot@chromium.org, Jul 21 2017

Labels: Hotlist-Google
Status: Fixed (was: Started)

Sign in to add a comment