New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 707234 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Apr 2018
Cc:
sczs@chromium.org
█ lpromero@chromium.org
mastiz@chromium.org
ios-bugs@chromium.org
█ tschumann@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

App crashes on entering valid passphrase for the second time in landscape mode.

Project Member Reported by pmadalla@chromium.org, Mar 31 2017 
App Version: 58.0.3029.39 dev
iOS Version: iOS 10
Device : iPhone7+, iPhone6+,iPhone 6s+

Steps to reproduce:

1- Launch chrome in landscape mode.
2- Sign in to chrome
3- Tap on Menu > Settings > Select the signed in user.
4- Tap on Sync > Encryption > tap on Encrypt all synced data with your own sync passphrase.
5- Enter invalid passphrase & confirm passphrase and tap on submit.
6- Now enter valid  passphrase & confirm passphrase and tap on submit.

Observed results:
App crashes
 
Expected results:
App should not crash

Number of times you were able to reproduce: 5/5
Bug reproducible after clean install: Yes
Bug reproducible after clearing cache and cookies: Yes
Bug reproducible on Chrome Mobile on Android: NA
Bug reproducible on Dolphin/Safari/Firefox: Safari : NA
Bug reproducible on current stable build (App Version, iOS Version): Yes in M57
Bug reproducible on the current beta channel build (App Version, iOS Version): Yes in M58

Link to Video :
https://drive.google.com/a/google.com/file/d/0B--UpU2GW2EpcHpfN0oyWXQ5ZzQ/view?usp=sharing

Crash log:
https://crash.corp.google.com/browse?stbtiq=c1e27f3480000000#0

Stack trace : 

Thread 0 CRASHED [EXC_SOFTWARE / UNCAUGHT_NS_EXCEPTION @ 0x00000001827aafd8 ] MAGIC SIGNATURE THREAD
Stack Quality6%Show frame trust levels
0x00000001827aafd8	(CoreFoundation + 0x0012cfd8 )	
0x000000018120c534	(libobjc.A.dylib + 0x00008534 )	
0x00000001826891ec	(CoreFoundation + 0x0000b1ec )	
0x00000001002dd5fc	(Chrome -sync_encryption_passphrase_collection_view_controller.mm:305 )	-[SyncEncryptionPassphraseCollectionViewController collectionView:cellHeightAtIndexPath:]
0x00000001001baac0	(Chrome -MDCCollectionViewController.m:173 )	-[MDCCollectionViewController sizeWithAttribute:]
0x00000001001ba8c4	(Chrome -MDCCollectionViewController.m:146 )	-[MDCCollectionViewController collectionView:layout:sizeForItemAtIndexPath:]
0x00000001891ffd00	(UIKit + 0x00935d00 )	
0x000000018920113c	(UIKit + 0x0093713c )	
0x0000000188a4ab70	(UIKit + 0x00180b70 )	
0x00000001889363e8	(UIKit + 0x0006c3e8 )	
0x000000018893c0bc	(UIKit + 0x000720bc )	
0x000000018898791c	(UIKit + 0x000bd91c )	
0x00000001888f0bf4	(UIKit + 0x00026bf4 )	
0x00000001892b0d28	(UIKit + 0x009e6d28 )	
0x0000000182699e20	(CoreFoundation + 0x0001be20 )	
0x0000000182699d1c	(CoreFoundation + 0x0001bd1c )	
0x00000001888df8d4	(UIKit + 0x000158d4 )	
0x00000001888d3930	(UIKit + 0x00009930 )	
0x00000001888f0bf4	(UIKit + 0x00026bf4 )	
0x0000000182699e20	(CoreFoundation + 0x0001be20 )	
0x0000000182699d1c	(CoreFoundation + 0x0001bd1c )	
0x00000001888df8d4	(UIKit + 0x000158d4 )	
0x00000001888d3930	(UIKit + 0x00009930 )	
0x0000000188993684	(UIKit + 0x000c9684 )	
0x00000001888f0bf4	(UIKit + 0x00026bf4 )	
0x0000000182699e20	(CoreFoundation + 0x0001be20 )	
0x0000000182699d1c	(CoreFoundation + 0x0001bd1c )	
0x00000001888df8d4	(UIKit + 0x000158d4 )	
0x00000001888d3930	(UIKit + 0x00009930 )	
0x00000001888f0bf4	(UIKit + 0x00026bf4 )	
0x0000000182699e20	(CoreFoundation + 0x0001be20 )	
0x0000000182699d1c	(CoreFoundation + 0x0001bd1c )	
0x00000001888df8d4	(UIKit + 0x000158d4 )	
0x00000001888d3930	(UIKit + 0x00009930 )	
0x000000018896b6a4	(UIKit + 0x000a16a4 )	
0x00000001888f0bf4	(UIKit + 0x00026bf4 )	
0x0000000182699e20	(CoreFoundation + 0x0001be20 )	
0x0000000182699d1c	(CoreFoundation + 0x0001bd1c )	
0x00000001888df8d4	(UIKit + 0x000158d4 )	
0x0000000188925dbc	(UIKit + 0x0005bdbc )	
0x0000000188fbffc0	(UIKit + 0x006f5fc0 )	
0x0000000188e2e728	(UIKit + 0x00564728 )	
0x00000001888d7098	(UIKit + 0x0000d098 )	
0x0000000185ac7270	(QuartzCore + 0x00117270 )	
0x0000000185abbde4	(QuartzCore + 0x0010bde4 )	
0x00000001888eb8ec	(UIKit + 0x000218ec )	
0x0000000188e2e2ac	(UIKit + 0x005642ac )	
0x000000018890f4b4	(UIKit + 0x000454b4 )	
0x000000018890f224	(UIKit + 0x00045224 )	
0x0000000188e2e250	(UIKit + 0x00564250 )	
0x00000001827455e8	(CoreFoundation + 0x000c75e8 )	
0x0000000182744cfc	(CoreFoundation + 0x000c6cfc )	
0x0000000182744a78	(CoreFoundation + 0x000c6a78 )	
0x00000001827b37a4	(CoreFoundation + 0x001357a4 )	
0x0000000182688948	(CoreFoundation + 0x0000a948 )	
0x000000018319a91c	(Foundation + 0x0000691c )	
0x00000001892c029c	(UIKit + 0x009f629c )	
0x000000018890f4b4	(UIKit + 0x000454b4 )	
0x00000001889ded80	(UIKit + 0x00114d80 )	
0x00000001892bfd14	(UIKit + 0x009f5d14 )	
0x00000001892c672c	(UIKit + 0x009fc72c )	
0x00000001892bf3e0	(UIKit + 0x009f53e0 )	
0x000000018899ee64	(UIKit + 0x000d4e64 )	
0x00000001888ffe1c	(UIKit + 0x00035e1c )	
0x000000018895d624	(UIKit + 0x00093624 )	
0x00000001889ca9d4	(UIKit + 0x001009d4 )	
0x0000000188984384	(UIKit + 0x000ba384 )	
0x0000000188a08810	(UIKit + 0x0013e810 )	
0x000000018898a30c	(UIKit + 0x000c030c )	
0x00000001002dd994	(Chrome -sync_encryption_passphrase_collection_view_controller.mm:387 )	-[SyncEncryptionPassphraseCollectionViewController signInPressed]
0x00000001827b0e7c	(CoreFoundation + 0x00132e7c )	
0x00000001826a62b0	(CoreFoundation + 0x000282b0 )	
0x00000001826aae78	(CoreFoundation + 0x0002ce78 )	
0x00000001001b13f8	(Chrome -MDCButtonBar.m:324 )	-[MDCButtonBar didTapButton:event:]
0x000000018890f0e8	(UIKit + 0x000450e8 )	
0x000000018890f068	(UIKit + 0x00045068 )	
0x00000001888f95dc	(UIKit + 0x0002f5dc )	
0x000000018890e94c	(UIKit + 0x0004494c )	
0x00000001001b3c24	(Chrome -MDCButton.m:335 )	-[MDCButton touchesEnded:withEvent:]
0x000000018890e468	(UIKit + 0x00044468 )	
0x0000000188909800	(UIKit + 0x0003f800 )	
0x00000001888da414	(UIKit + 0x00010414 )	
0x00000001890d3f60	(UIKit + 0x00809f60 )	
0x00000001890ce6bc	(UIKit + 0x008046bc )	
0x00000001890ceae8	(UIKit + 0x00804ae8 )	
0x0000000182759420	(CoreFoundation + 0x000db420 )	
0x0000000182758d90	(CoreFoundation + 0x000dad90 )	
0x000000018275699c	(CoreFoundation + 0x000d899c )	
0x0000000182686d90	(CoreFoundation + 0x00008d90 )	
0x00000001840f0070	(GraphicsServices + 0x0000c070 )	
0x000000018893f12c	(UIKit + 0x0007512c )	
0x00000001000b87a0	(Chrome -chrome_exe_main.mm:63 )	main
0x0000000181695598	(libdyld.dylib + 0x00004598 )

Comment 1 by pnoland@chromium.org, Apr 3 2017

Cc: bzanotti@chromium.org lpromero@chromium.org
Looks like an ios ui framework related crash(possibly similar to crbug/680098) 
The crash is happening in SyncEncryptionPassphraseCollectionViewController, but the component in the video that's active right before the crash is SyncCreatePassphraseCollectionViewController. I am guessing this is due to the call [super signInPressed]; in the create passphrase controller's signinPressed method. Maybe the reloadData call when the passphrases mismatch is causing something to go out of sync? 

I'm not too sure where to go from here. bzanotti@ or lpromero@, any pointers? You've both modified this file somewhat recently.

Comment 2 by edchin@chromium.org, Apr 3 2017

Cc: -lpromero@chromium.org -bzanotti@chromium.org sczs@chromium.org
Labels: ReleaseBlock-Stable M-58
Owner: lpromero@chromium.org
Status: Assigned (was: Untriaged)
Please evaluate.

Comment 3 by lpromero@chromium.org, Apr 4 2017

Status: Started (was: Assigned)
The fact that it's only on Plus phones might be because on those devices the UI is not fullscreen. Still doesn't explain the issue though.

Comment 4 by lpromero@chromium.org, Apr 4 2017 

I didn't yet repro on a Dev build.

Comment 5 by lpromero@chromium.org, Apr 7 2017 

I repro on Beta.

Comment 7 by lpromero@chromium.org, Apr 7 2017

Labels: -ReleaseBlock-Stable
I also repro on 57 App Store. It is probably a pretty old crash.

Comment 8 by lpromero@chromium.org, Apr 13 2017

Labels: -Pri-2 -M-58 M-60 Pri-1

Comment 10 by lpromero@chromium.org, Jun 23 2017

Labels: -Pri-1 -M-60 Pri-2

Comment 11 by lpromero@chromium.org, Jul 10 2017

Cc: lpromero@chromium.org
Owner: ----
Status: Available (was: Started)
My investigations didn't lead to a solution yet. Marking Available if someone wants to take a stab at it.

Comment 12 by s...@chromium.org, Jan 17 2018

Labels: Sync-Triaged SyncHandoff2018
Project Member

Comment 13 by PranavkRobot, Mar 19 2018

Labels: crash-BugIsFixed

Comment 14 by mastiz@chromium.org, Apr 9 2018

Status: Fixed (was: Available)
Looks like it went away, closing.
►

Sign in to add a comment