New issue
Advanced search Search tips

Issue 707204 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[LargeIconService] Pass results as unique_ptr

Project Member Reported by jkrcal@chromium.org, Mar 31 2017

Issue description

Taking ownership by plain pointer in LargeIconResult a bit ugly. Do
 - change these FallbackIconStyle constructors to take unique_ptr, and
 - change the callbacks to pass unique_ptrs of LargeIconResult

This would allow us to get rid of "new ..." and to use std::move out things out LargeIconResult if you need to.
(see, e.g. LargeIconCache::CloneLargeIconResult)
 
Cc: jkrcal@chromium.org
Owner: ----
Status: Available (was: Assigned)
Dropping the bug as it does not align with any of my current projects.

Status: Untriaged (was: Available)
Available, but no owner or component? Please find a component, as no one will ever find this without one.

Sign in to add a comment