ClearBrowsingDataPreferencesTest fails with StrictModeDiskReadViolation |
||
Issue description
C 18.891s Main [FAIL] org.chromium.chrome.browser.preferences.privacy.ClearBrowsingDataPreferencesTest#testFooterNonsigned:
C 18.891s Main android.os.StrictMode$StrictModeViolation: policy=18153503 violation=2
Logcat:
03-31 10:47:28.948 26813-26813/org.chromium.chrome D/StrictMode: StrictMode policy violation; ~duration=23 ms: android.os.StrictMode$StrictModeDiskReadViolation: policy=18153503 violation=2
at android.os.StrictMode$AndroidBlockGuardPolicy.onReadFromDisk(StrictMode.java:1293)
at java.io.UnixFileSystem.checkAccess(UnixFileSystem.java:249)
at java.io.File.exists(File.java:780)
at android.app.ContextImpl.getDataDir(ContextImpl.java:1938)
at android.app.ContextImpl.getPreferencesDir(ContextImpl.java:466)
at android.app.ContextImpl.getSharedPreferencesPath(ContextImpl.java:627)
at android.app.ContextImpl.getSharedPreferences(ContextImpl.java:345)
at android.content.ContextWrapper.getSharedPreferences(ContextWrapper.java:164)
at android.preference.PreferenceManager.getSharedPreferences(PreferenceManager.java:471)
at android.preference.Preference.getSharedPreferences(Preference.java:1064)
at android.preference.Preference.dispatchSetInitialValue(Preference.java:1386)
at android.preference.Preference.onAttachedToHierarchy(Preference.java:1185)
at android.preference.PreferenceGroup.addPreference(PreferenceGroup.java:163)
at android.preference.PreferenceGroup.addItemFromInflater(PreferenceGroup.java:105)
at android.preference.PreferenceGroup.addItemFromInflater(PreferenceGroup.java:104)
at android.preference.GenericInflater.rInflate(GenericInflater.java:490)
at android.preference.GenericInflater.inflate(GenericInflater.java:327)
at android.preference.GenericInflater.inflate(GenericInflater.java:264)
at android.preference.PreferenceManager.inflateFromResource(PreferenceManager.java:280)
at android.preference.PreferenceFragment.addPreferencesFromResource(PreferenceFragment.java:326)
at org.chromium.chrome.browser.preferences.privacy.ClearBrowsingDataPreferences.onCreate(ClearBrowsingDataPreferences.java:505)
,
Apr 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/92933ff654ebb9bb8be0de9eaad60668eb395443 commit 92933ff654ebb9bb8be0de9eaad60668eb395443 Author: dullweber <dullweber@chromium.org> Date: Mon Apr 03 17:32:28 2017 Add StrictMode exception for addPreferencesFromResource calls. Add a helper method that disables StrictMode temporarily and loads preferences to ClearBrowsingDataPrefences, AboutChromePreferences and AutofillAndPaymentsPreferences to avoid StrictModeViolation errors. BUG= 707174 ,692125, 692130 Review-Url: https://codereview.chromium.org/2787323002 Cr-Commit-Position: refs/heads/master@{#461462} [modify] https://crrev.com/92933ff654ebb9bb8be0de9eaad60668eb395443/chrome/android/java/src/org/chromium/chrome/browser/preferences/AboutChromePreferences.java [modify] https://crrev.com/92933ff654ebb9bb8be0de9eaad60668eb395443/chrome/android/java/src/org/chromium/chrome/browser/preferences/MainPreferences.java [add] https://crrev.com/92933ff654ebb9bb8be0de9eaad60668eb395443/chrome/android/java/src/org/chromium/chrome/browser/preferences/PreferenceUtils.java [modify] https://crrev.com/92933ff654ebb9bb8be0de9eaad60668eb395443/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillAndPaymentsPreferences.java [modify] https://crrev.com/92933ff654ebb9bb8be0de9eaad60668eb395443/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferences.java [modify] https://crrev.com/92933ff654ebb9bb8be0de9eaad60668eb395443/chrome/android/java_sources.gni
,
Apr 4 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by dullweber@chromium.org
, Mar 31 2017