New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 707155 link

Starred by 1 user
Status: Assigned
Owner:
█ youcheng@chromium.org
Last visit > 30 days ago
Cc:
█ youcheng@chromium.org
█ yhong@chromium.org
█ phoenixshen@chromium.org
█ pihsun@chromium.org
yllin@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

factory: revise golden eye output and factory.zip

Project Member Reported by hungte@chromium.org, Mar 31 2017 
Temporary assign to littlecvr - feel free to find other owners for this.

Currently the factory stuff on golden eye is a single factory.zip, containing:
 - toolkit (10~30M)
 - unsigned factory install shim (100~200M)
 - netboot fw +kernel (~10M)
 - setup/ (~1M)
 - hwid (~few K)
 - bundle and completion scripts

I think we do want to make it easier to get toolkits, also easier to find factory resources, easier to finalize_bundle, without creating too many files on golden eye.

It seems that the most important ones are
 - toolkit (worthy to have its own file output)
 - factory install shim (should be merged to images.zip, or its own archive, just like test images)

And it's fine to have a "anything else", containing
 - hwid (which people can directly download from CPFE, but bundles should have an initial version)
 - setup/ (it is fine if only finalize_bundle will feed these scripts, not in factory.zip, 
           or just have a bootstrap script in factory.zip for setup & factory docker server images)
 - completion script (optional, or maybe we should merge into factory shim)
 - netboot (not sure how this should appear - maybe merge with the firmware archives on golden eye?

Comment 1 by littlecvr@chromium.org, Apr 5 2017 

If `finalize_bundle` failed after the download step, the resources (test image, release image, factory toolkit, etc.) just downloaded remain on the local disk. Next time the user runs `finalize_bundle` (after fixing the problem, of course), we can take advantage of this fact and skip the download step.

But one problem caused by this issue is that it's hard to tell if that existing toolkit matches the requested version. Because currently a "toolkit" version in the config actually refers to the version of factory.zip, not just toolkit itself. That is, it also contains the netboot firmware and factory shim. So it's not enough to check only the toolkit version, we would have to check netboot firmware, factory shim, etc.

Comment 2 by hungte@chromium.org, Jun 7 2017

Owner: youcheng@chromium.org
Status: Assigned (was: Untriaged)
Had some discussion today and we think, as first step before Easy Bundle creation is ready, we want:

 - factory install shim should be moved to its own archive, say factory_shim, as a single file (no *.sh, no netboot).
 - toolkits, setup, netboot, (include hwid at the moment) may stay in factory.zip

CPFE may also change FACTORY_IMAGE_ARCHIVE and FACTORY_IMAGE to FACTORY_SHIM_IMAGE, FACTORY_SHIM_ARCHIVE, and FACTORY_ZIP.


Temporarily assign to youcheng since he has done lots of build/umpire/bundle changes.
►

Sign in to add a comment