New issue
Advanced search Search tips

Issue 707144 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Jan 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

Browser shutdown is not properly handled on user exit (Ctrl + Shift + Q)

Reported by ase...@yandex-team.ru, Mar 31 2017

Issue description

Chrome Version       : 57.0.2978.110

What steps will reproduce the problem?
(1) Open browser
(2) Open some urls
(2) Press Ctrl + Shift + Q

What is the expected result?
(1) "chrome_shutdown_ms.txt" file is created in "User Data" directory
(2) shutdown histograms are created on the next browser start (i.e. "Shutdown.window_close.time2")

What happens instead?
"chrome_shutdown_ms.txt" and expected histograms is not created

 
Labels: Needs-Triage-M57
Cc: rbasuvula@chromium.org
Labels: Needs-Feedback
Tested in chrome # 57.0.2987.133 and Canary #59.0.3062.0 on win 10.0 & 7 and not able to reproduce the issue.Please find the screen shots for your reference.

@Reporter: Could you please let me know if i have missed anything and if possible,Please restart your system and create new profile without extensions and apps.Re-check once in latest stable #57.0.2987.133 and Canary #59.0.3062.0 and let us know the observations of the issue which would help us to triage the issue further.

Thanks in Advance.
707144.PNG
89.8 KB View Download
Hello, rbasuvula

Have you done the steps to reproduce?
Can you find "Shutdown.window_close.time2" histogram on chrome://histograms page?
It measures time that browser shutdown takes.

Thank you.
Project Member

Comment 4 by sheriffbot@chromium.org, Apr 4 2017

Labels: -Needs-Feedback
Thank you for providing more feedback. Adding requester "rbasuvula@chromium.org" to the cc list and removing "Needs-Feedback" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: kkaluri@chromium.org
Labels: Needs-Feedback
Tested this issue on Windows 10 with chrome #57.0.2987.133

Observed "Shutdown.window_close.time2" histogram on chrome://histograms page

aseren@ could you please update chrome to latest update and let us know your observations.
Issue 707144.PNG
38.7 KB View Download
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/121533e5f6bc5a80d8fbc7b9cf8ae19f8a21243d

commit 121533e5f6bc5a80d8fbc7b9cf8ae19f8a21243d
Author: Aleksei Seren <aseren@yandex-team.ru>
Date: Tue Nov 28 20:11:18 2017

Fix shutdown histograms on browser closing.

Shutdown histograms were not properly written because of several issues:
1) There is an incorrect calculation of current open browsers which
have not yet started to close. This leads to the fact that
browser_shutdown::OnShutdownStarting() is not called in case of
several browsers shutdown.
2) During the closure of the browser we are trying to find if there is any
background Chrome applications with help of KeepAliveRegistry::IsKeepingAlive()
function call, which is actually tracking running Browsers also (i.e. it can
return true even if there is no background application). So it is needed to
introduce new function to track background applications only.

R=sky@chromium.org
BUG= 707147 
BUG= 707144 

Change-Id: If4f7c080965c95e2c0b810817e94a09f3a52ba51
Reviewed-on: https://chromium-review.googlesource.com/760356
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Nicolas Dossou-Gbété <dgn@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519810}
[add] https://crrev.com/121533e5f6bc5a80d8fbc7b9cf8ae19f8a21243d/chrome/browser/browser_shutdown_browsertest.cc
[modify] https://crrev.com/121533e5f6bc5a80d8fbc7b9cf8ae19f8a21243d/chrome/browser/ui/browser.cc
[modify] https://crrev.com/121533e5f6bc5a80d8fbc7b9cf8ae19f8a21243d/chrome/browser/ui/browser.h
[modify] https://crrev.com/121533e5f6bc5a80d8fbc7b9cf8ae19f8a21243d/chrome/browser/ui/browser_list.cc
[modify] https://crrev.com/121533e5f6bc5a80d8fbc7b9cf8ae19f8a21243d/chrome/browser/ui/browser_list.h
[modify] https://crrev.com/121533e5f6bc5a80d8fbc7b9cf8ae19f8a21243d/chrome/test/BUILD.gn
[modify] https://crrev.com/121533e5f6bc5a80d8fbc7b9cf8ae19f8a21243d/components/keep_alive_registry/keep_alive_registry.cc
[modify] https://crrev.com/121533e5f6bc5a80d8fbc7b9cf8ae19f8a21243d/components/keep_alive_registry/keep_alive_registry.h

Status: Fixed (was: Unconfirmed)

Sign in to add a comment