New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 707131 link

Starred by 1 user
Status: Fixed
Owner:
█ scottchen@chromium.org
Last visit > 30 days ago
Closed: Apr 2017
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
█ msrchandra@chromium.org
█ ranjitkan@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression : Unnecessarily both the focus highlights are seen at the same time on languages in "Add languages" dialog.

Reported by avsha...@etouch.net, Mar 31 2017 
Chrome Version : 59.0.3057.0 (Official Build) a064840eb26683687c53dc6fa6b5c29a2c418b5c-refs/heads/master@{#460966} 32/64 bit
OS : Windows (7,8,10)

What steps will reproduce the problem?
1. Launch chrome and navigate to chrome://md-settings/languages.
2. Expand the Languages section and click on "Add languages" button.
3. Hit Tab key and observe the overlapping of focus on the first language in the list.  

Actual : Unnecessarily both the focus highlights are seen at the same time on languages in "Add languages" dialog and both the focus highlights are overlapping with each other.

Expected : Instead, only one focus highlight should be seen at a time on a language and focus highlights should not overlap.

This is a regression issue broken in ‘M-59’, below is the Manual Regression range and will soon update other info.
Good build : 59.0.3056.0
Bad build : 59.0.3057.0

Note : Will soon update other info once the Linux and Mac OS build #59.0.3057.0 is available.
Actual_Result.mp4
822 KB View Download
Expected_Result.mp4
818 KB View Download

Comment 1 by rbasuvula@chromium.org, Mar 31 2017

Cc: rbasuvula@chromium.org
Labels: hasbisect-per-revision
Owner: scottchen@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build:59.0.3056.0 (Revision:460603).
Bad build:59.0.3057.0 (Revision:460966).

You are probably looking for a change made after 460936 (known good), but no later than 460937 (first known bad).

CHANGE-LOG URL:
---------------
https://chromium.googlesource.com/chromium/src/+log/d0203954892c94a15b4f5843bdc519b2be81f0bc..27793e2b00cd4f06e24cde9599be5693006ed02b

From the CL above, assigning the issue to the concern owner

@scottchen: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Review-Url: https://codereview.chromium.org/2702523005
Note :Able to reproduce the issue in Win 10.0,Ubuntu 14.04 & Mac 10.12.3 and Able to reproduce in latest Canary #59.0.3056.0

Comment 2 by rbasuvula@chromium.org, Mar 31 2017

Labels: OS-Linux OS-Mac

Comment 3 by scottchen@chromium.org, Mar 31 2017

Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2d84fb544158248447cf01d8a1cca146069d48a9

commit 2d84fb544158248447cf01d8a1cca146069d48a9
Author: scottchen <scottchen@chromium.org>
Date: Sat Apr 01 02:02:39 2017

MD Settings: remove focus background from add-language list.

BUG= 707131 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2788103003
Cr-Commit-Position: refs/heads/master@{#461305}

[modify] https://crrev.com/2d84fb544158248447cf01d8a1cca146069d48a9/chrome/browser/resources/settings/languages_page/add_languages_dialog.html

Comment 5 by scottchen@chromium.org, Apr 3 2017

Status: Fixed (was: Started)

Comment 6 by kkaluri@chromium.org, Apr 4 2017

Labels: TE-Verified-59.0.3061.3 TE-Verified-M59
verified this issue on Windows 10 and Mac 10.12.4 with chrome #59.0.3061.3 and in Ubuntu14.04  with chrome #59.0.3061.0
Observed no focus in background of language names in "chrome://settings/languages", hence adding TE-verified labels.

Attaching the screen-cast for reference
Issue 707131.mp4
414 KB View Download
►

Sign in to add a comment