New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 707130 link

Starred by 1 user
Status: Fixed
Owner:
dgozman@chromium.org
Closed: Apr 2017
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
█ msrchandra@chromium.org
█ ranjitkan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression:[DevTools] Unnecessary Settings page gets closed on selecting any devices from drop down list.

Reported by dchau...@etouch.net, Mar 31 2017 
Chrome Version: 59.0.3057.0 (Official Build)a064840eb26683687c53dc6fa6b5c29a2c418b5c-refs/heads/master@{#460966} 32/64-bit.
OS: Windows(7,8,10)

What steps will reproduce the problem?
1. Launch chrome, open DevTools window and press 'F1' key to open Settings page.
2. Go to 'Devices' section and click on 'Add custom devices' button.
3. Now, select any devices (Desktop) from drop down list and observe.

Unnecessary Settings page gets closed.
Settings page should not get closed.

This is a regression issue, broken in M-59 series, will soon update other info.

Comment 1 by dchau...@etouch.net, Mar 31 2017 

Below is manual regression range for the above issue.

Good build: 59.0.3056.0
Bad build: 59.0.3057.0

Note: Will soon update the behavior on other OS.

Kindly review the attached screen-cast for reference.
Actual behavior.mp4
667 KB View Download
Expected behavior.mp4
497 KB View Download

Comment 2 by rbasuvula@chromium.org, Mar 31 2017

Cc: rbasuvula@chromium.org
Labels: hasbisect-per-revision ReleaseBlock-Stable OS-Linux
Owner: dgozman@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build:59.0.3056.0 (Revision:460603).
Bad build:59.0.3057.0 (Revision:460966).

You are probably looking for a change made after 460910 (known good), but no later than 460911 (first known bad).

CHANGE-LOG URL:
---------------
https://chromium.googlesource.com/chromium/src/+log/0c64e3912571118d628f513ccc3a7eb6224099d8..f05869713aa6363110a45d45a03ebb0c946744d8

From the CL above, assigning the issue to the concern owner

@dgozman: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Review-Url: https://codereview.chromium.org/2790613003
Note :Able to reproduce the issue in Win 10.0,Ubuntu 14.04 & Not in Mac 10.12.3 and Able to reproduce in latest Canary #59.0.3057.0
Adding Release Block-Stable for this issue.Please remove if not the case.
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/345ac542f1ee7737574e70ec508a5ecd13cd4006

commit 345ac542f1ee7737574e70ec508a5ecd13cd4006
Author: dgozman <dgozman@chromium.org>
Date: Thu Apr 06 01:50:48 2017

[DevTools] Account for synthetic events in deepElementFromPoint()

Synthetic events have zero coordinates and return incorrect element from
deepElementFromPoint() call. This leads to GlassPane handling the click
incorrectly.

BUG= 707130 

Review-Url: https://codereview.chromium.org/2800733004
Cr-Commit-Position: refs/heads/master@{#462318}

[modify] https://crrev.com/345ac542f1ee7737574e70ec508a5ecd13cd4006/third_party/WebKit/Source/devtools/front_end/dom_extension/DOMExtension.js
[modify] https://crrev.com/345ac542f1ee7737574e70ec508a5ecd13cd4006/third_party/WebKit/Source/devtools/front_end/ui/GlassPane.js

Comment 4 by dgozman@chromium.org, Apr 6 2017

Status: Fixed (was: Assigned)

Comment 5 by sureshkumari@chromium.org, Apr 11 2017

Labels: TE-Verified-M59 TE-Verified-59.0.3067.0 TE-Verified-59.0.3067.6
Verified the issue on Windows-7 using chrome version #59.0.3067.6 and Ubuntu 14.04 using chrome version #59.0.3067.0(due to non-availability of chrome dev build #59.0.3067.6 for OS-Linux) as per comment #1.

Observed that the fix is working as expected.Hence adding the verified labels.

Please find the attached screen cast for reference.

Thanks.
707130.mp4
666 KB View Download
►

Sign in to add a comment