New issue
Advanced search Search tips

Issue 707123 link

Starred by 1 user
Status: WontFix
Owner:
mlippautz@chromium.org
Closed: Mar 2017
Cc:
yhirano@chromium.org
haraken@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Linux , All
Pri: 1
Type: Bug

Blocking:
issue 594639



Sign in to add a comment

TraceWrapperMember crashes when used as value type of HeapHashMap

Project Member Reported by kouhei@chromium.org, Mar 31 2017 
POC: https://codereview.chromium.org/2788833002

This is blocking ES6 modules implementation

Comment 1 by kouhei@chromium.org, Mar 31 2017

Status: WontFix (was: Untriaged)
It looks like this was the bug in the test code. I'll investigate more
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 5 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e0828110c362763556738df32990abbc38370ebc

commit e0828110c362763556738df32990abbc38370ebc
Author: kouhei <kouhei@chromium.org>
Date: Wed Apr 05 12:53:42 2017

Allow null other.m_parent in TraceWrapperMember::operator= if other is nullptr.

This CL fixes the DCHECK condition in TraceWrapperMember::operator= to allow
assignment of null TraceWrapperMember.

This CL allows TraceWrapperMember to be used in HeapHash{Set,Map}, as
HashTable::rehash operations involve assignment of empty==null TraceWrapperMembers.

BUG= 594639 ,  707123 

Review-Url: https://codereview.chromium.org/2802593002
Cr-Commit-Position: refs/heads/master@{#462044}

[modify] https://crrev.com/e0828110c362763556738df32990abbc38370ebc/third_party/WebKit/Source/bindings/core/v8/TraceWrapperMember.h
[modify] https://crrev.com/e0828110c362763556738df32990abbc38370ebc/third_party/WebKit/Source/bindings/core/v8/TraceWrapperMemberTest.cpp
►

Sign in to add a comment