New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 707116 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature



Sign in to add a comment

Add memory usage logs to the feedback report

Project Member Reported by hctsai@chromium.org, Mar 31 2017

Issue description

While multiple memory pressure issues are being tracked, we need to enhance the feedback report by adding memory consumption info. The first approach would be using the 'top' to output most memory consuming processes (RES). 

top -o "+%MEM" -bn 1 | head -n <number of processes>

 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/e8c31d5a35b3d6e638e54a1101cebd9c93a6e455

commit e8c31d5a35b3d6e638e54a1101cebd9c93a6e455
Author: Hsu-Cheng Tsai <hctsai@google.com>
Date: Fri Mar 31 12:31:47 2017

debugd: Add top (memory mode) to user feedback.

Use 'top' to show top 50 memory consumption process.

BUG= chromium:707116 
TEST=manual

Change-Id: I6e7d7ac0208250acbe6f5a07f81bf93c78f82afd
Reviewed-on: https://chromium-review.googlesource.com/464487
Commit-Ready: Hsu-Cheng Tsai <hctsai@chromium.org>
Tested-by: Hsu-Cheng Tsai <hctsai@chromium.org>
Reviewed-by: Ben Cheng <bccheng@chromium.org>

[modify] https://crrev.com/e8c31d5a35b3d6e638e54a1101cebd9c93a6e455/debugd/src/log_tool.cc

Comment 2 by bccheng@google.com, Apr 6 2017

Labels: Merge-Request-58
Request merge to R58 to facilitate issue triage.
Please add applicable OSs.  Thanks!
M58 Stable is approaching soon! 

Please confirm whether the fix is verified in canary. If yes, request a merge to M58.

Comment 5 by bccheng@google.com, Apr 7 2017

Labels: OS-Chrome
I have checked some CrOS feedback from R59 with the change and the content looks correct. Also this is a super low-risk change. Thanks!
Project Member

Comment 6 by sheriffbot@chromium.org, Apr 7 2017

Labels: -Merge-Request-58 Hotlist-Merge-Approved Merge-Approved-58
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 7 by bccheng@google.com, Apr 7 2017

Cc: bhthompson@chromium.org
This change is for ChromeOS, so I think the branch is release-R58-9334.B.
Project Member

Comment 8 by bugdroid1@chromium.org, Apr 7 2017

Labels: merge-merged-release-R58-9334.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/ca86ee9d9d5623b070a91de9570dca0b6e24e1d8

commit ca86ee9d9d5623b070a91de9570dca0b6e24e1d8
Author: Hsu-Cheng Tsai <hctsai@google.com>
Date: Fri Apr 07 05:48:05 2017

debugd: Add top (memory mode) to user feedback.

Use 'top' to show top 50 memory consumption process.

BUG= chromium:707116 
TEST=manual

Change-Id: I6e7d7ac0208250acbe6f5a07f81bf93c78f82afd
Reviewed-on: https://chromium-review.googlesource.com/464487
Commit-Ready: Hsu-Cheng Tsai <hctsai@chromium.org>
Tested-by: Hsu-Cheng Tsai <hctsai@chromium.org>
Reviewed-by: Ben Cheng <bccheng@chromium.org>
(cherry picked from commit e8c31d5a35b3d6e638e54a1101cebd9c93a6e455)
Reviewed-on: https://chromium-review.googlesource.com/471227
Reviewed-by: Chung-yih Wang <cywang@google.com>
Tested-by: Ben Cheng <bccheng@chromium.org>
Commit-Queue: Ben Cheng <bccheng@chromium.org>

[modify] https://crrev.com/ca86ee9d9d5623b070a91de9570dca0b6e24e1d8/debugd/src/log_tool.cc

Project Member

Comment 9 by sheriffbot@chromium.org, Apr 10 2017

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 10 by bccheng@google.com, Apr 11 2017

Labels: -Hotlist-Merge-Approved -Merge-Approved-58
Components: Platform>Apps>Feedback
Status: Fixed (was: Assigned)

Comment 13 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 14 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)

Sign in to add a comment