New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 707104 link

Starred by 1 user

Issue metadata

Status: Duplicate
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: ----
Type: Feature



Sign in to add a comment

Experiment to specifically request CVC if missing during Chrome/Payments Upstream

Project Member Reported by jsaul@google.com, Mar 31 2017

Issue description

Feature description:
During a checkout flow, if CVC was not detected, Chrome is unable to offer credit card upload to Google Payments.  In these cases, we would like to surface a textfield in the offer-to-save bubble that allows continuing with upload if the user explicitly provides the card's CVC.

Eng owner: jsaul@
Product owner: sieke@

Design doc: https://docs.google.com/document/d/13_Zpxlr0p-hjKO_zW5GXNcjg3zhAYMgSfOUNfHSUKbU

Are you planning on experimenting before launch?
Yes.  A large portion of this feature is gaining new data on what the conversion rate would be when additional data is necessary from the user.

Any new strings?
Probably one or two in the bubble (see design doc mock).

Any implications for Google webservices (i.e. sync, translate)?
There shouldn't be.  There won't be any changes to Chrome/Payments/Sync communication.

Binary size?
Unknown at this time

Do the existing perf tests exercise all aspects of your new feature(s)?
Unknown at this time

 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/314052191919e73f2ed0c7b8014c842103d5688c

commit 314052191919e73f2ed0c7b8014c842103d5688c
Author: jsaul <jsaul@google.com>
Date: Thu Apr 13 23:26:18 2017

When credit card upload to Google Payments is blocked due
to missing CVC in checkout flow, offer upload by requesting CVC
from user.

BUG= 707104 

Review-Url: https://codereview.chromium.org/2789843004
Cr-Commit-Position: refs/heads/master@{#464603}

[modify] https://crrev.com/314052191919e73f2ed0c7b8014c842103d5688c/android_webview/native/aw_autofill_client.cc
[modify] https://crrev.com/314052191919e73f2ed0c7b8014c842103d5688c/android_webview/native/aw_autofill_client.h
[modify] https://crrev.com/314052191919e73f2ed0c7b8014c842103d5688c/chrome/browser/about_flags.cc
[modify] https://crrev.com/314052191919e73f2ed0c7b8014c842103d5688c/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/314052191919e73f2ed0c7b8014c842103d5688c/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/314052191919e73f2ed0c7b8014c842103d5688c/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/314052191919e73f2ed0c7b8014c842103d5688c/chrome/browser/ui/autofill/chrome_autofill_client.cc
[modify] https://crrev.com/314052191919e73f2ed0c7b8014c842103d5688c/chrome/browser/ui/autofill/chrome_autofill_client.h
[modify] https://crrev.com/314052191919e73f2ed0c7b8014c842103d5688c/chrome/browser/ui/autofill/save_card_bubble_controller_impl.cc
[modify] https://crrev.com/314052191919e73f2ed0c7b8014c842103d5688c/chrome/browser/ui/autofill/save_card_bubble_controller_impl.h
[modify] https://crrev.com/314052191919e73f2ed0c7b8014c842103d5688c/chrome/browser/ui/autofill/save_card_bubble_controller_impl_unittest.cc
[modify] https://crrev.com/314052191919e73f2ed0c7b8014c842103d5688c/chrome/browser/ui/cocoa/autofill/save_card_bubble_view_bridge.mm
[modify] https://crrev.com/314052191919e73f2ed0c7b8014c842103d5688c/chrome/browser/ui/cocoa/autofill/save_card_bubble_view_unittest.mm
[modify] https://crrev.com/314052191919e73f2ed0c7b8014c842103d5688c/chrome/browser/ui/views/autofill/card_unmask_prompt_views.cc
[modify] https://crrev.com/314052191919e73f2ed0c7b8014c842103d5688c/chrome/browser/ui/views/autofill/save_card_bubble_views.cc
[modify] https://crrev.com/314052191919e73f2ed0c7b8014c842103d5688c/chrome/browser/ui/views/autofill/save_card_bubble_views.h
[add] https://crrev.com/314052191919e73f2ed0c7b8014c842103d5688c/chrome/browser/ui/views/autofill/view_util.cc
[add] https://crrev.com/314052191919e73f2ed0c7b8014c842103d5688c/chrome/browser/ui/views/autofill/view_util.h
[modify] https://crrev.com/314052191919e73f2ed0c7b8014c842103d5688c/components/autofill/core/browser/BUILD.gn
[modify] https://crrev.com/314052191919e73f2ed0c7b8014c842103d5688c/components/autofill/core/browser/autofill_client.h
[modify] https://crrev.com/314052191919e73f2ed0c7b8014c842103d5688c/components/autofill/core/browser/autofill_experiments.cc
[modify] https://crrev.com/314052191919e73f2ed0c7b8014c842103d5688c/components/autofill/core/browser/autofill_experiments.h
[modify] https://crrev.com/314052191919e73f2ed0c7b8014c842103d5688c/components/autofill/core/browser/autofill_manager.cc
[modify] https://crrev.com/314052191919e73f2ed0c7b8014c842103d5688c/components/autofill/core/browser/autofill_manager.h
[modify] https://crrev.com/314052191919e73f2ed0c7b8014c842103d5688c/components/autofill/core/browser/autofill_manager_unittest.cc
[modify] https://crrev.com/314052191919e73f2ed0c7b8014c842103d5688c/components/autofill/core/browser/autofill_metrics.h
[modify] https://crrev.com/314052191919e73f2ed0c7b8014c842103d5688c/components/autofill/core/browser/test_autofill_client.cc
[modify] https://crrev.com/314052191919e73f2ed0c7b8014c842103d5688c/components/autofill/core/browser/test_autofill_client.h
[add] https://crrev.com/314052191919e73f2ed0c7b8014c842103d5688c/components/autofill/core/browser/ui/mock_save_card_bubble_controller.cc
[add] https://crrev.com/314052191919e73f2ed0c7b8014c842103d5688c/components/autofill/core/browser/ui/mock_save_card_bubble_controller.h
[rename] https://crrev.com/314052191919e73f2ed0c7b8014c842103d5688c/components/autofill/core/browser/ui/save_card_bubble_controller.h
[modify] https://crrev.com/314052191919e73f2ed0c7b8014c842103d5688c/components/autofill_strings.grdp
[modify] https://crrev.com/314052191919e73f2ed0c7b8014c842103d5688c/ios/chrome/browser/ui/autofill/autofill_client_ios.h
[modify] https://crrev.com/314052191919e73f2ed0c7b8014c842103d5688c/ios/chrome/browser/ui/autofill/autofill_client_ios.mm
[modify] https://crrev.com/314052191919e73f2ed0c7b8014c842103d5688c/tools/metrics/histograms/histograms.xml

Components: -UI>Browser>Autofill>Payments UI>Browser>Payments
Project Member

Comment 4 by sheriffbot@chromium.org, Jul 21 2017

Labels: Hotlist-Google

Comment 5 by jsaul@google.com, Aug 11 2017

Mergedinto: 754774
Status: Duplicate (was: Started)
Since this issue was created as a feature request rather than a launch-tracking bug, merging it into new launch bug 754774.
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b93fd34d7c64b73b1be8f7da740f169b30cc0f37

commit b93fd34d7c64b73b1be8f7da740f169b30cc0f37
Author: Jared Saul <jsaul@google.com>
Date: Thu Aug 31 18:50:47 2017

Expand SaveCardPromptMetric for Upstream's CVC fix flow

Bug:  707104 
Change-Id: I9b6331a02e4551ca20ad422570a86701fa143ac2
Reviewed-on: https://chromium-review.googlesource.com/644618
Commit-Queue: Jared Saul <jsaul@google.com>
Reviewed-by: Rachel Blum <groby@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498936}
[modify] https://crrev.com/b93fd34d7c64b73b1be8f7da740f169b30cc0f37/chrome/browser/ui/autofill/save_card_bubble_controller_impl.cc
[modify] https://crrev.com/b93fd34d7c64b73b1be8f7da740f169b30cc0f37/chrome/browser/ui/autofill/save_card_bubble_controller_impl.h
[modify] https://crrev.com/b93fd34d7c64b73b1be8f7da740f169b30cc0f37/chrome/browser/ui/autofill/save_card_bubble_controller_impl_unittest.cc
[modify] https://crrev.com/b93fd34d7c64b73b1be8f7da740f169b30cc0f37/chrome/browser/ui/cocoa/autofill/save_card_bubble_view_unittest.mm
[modify] https://crrev.com/b93fd34d7c64b73b1be8f7da740f169b30cc0f37/chrome/browser/ui/views/autofill/save_card_bubble_views.cc
[modify] https://crrev.com/b93fd34d7c64b73b1be8f7da740f169b30cc0f37/components/autofill/core/browser/autofill_metrics.h
[modify] https://crrev.com/b93fd34d7c64b73b1be8f7da740f169b30cc0f37/components/autofill/core/browser/ui/mock_save_card_bubble_controller.h
[modify] https://crrev.com/b93fd34d7c64b73b1be8f7da740f169b30cc0f37/components/autofill/core/browser/ui/save_card_bubble_controller.h
[modify] https://crrev.com/b93fd34d7c64b73b1be8f7da740f169b30cc0f37/tools/metrics/histograms/enums.xml

Sign in to add a comment