New issue
Advanced search Search tips

Issue 707089 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Add more WTF::PtrUtil unit tests

Project Member Reported by cblume@chromium.org, Mar 31 2017

Issue description

I recently added a unit test to cover a case that was failing.
But the other cases were not covered either.

Write some tests to cover everything in WTF::PtrUtil.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9a254ff19df85b20fdc6b6431f9e8cf7f6912cc8

commit 9a254ff19df85b20fdc6b6431f9e8cf7f6912cc8
Author: cblume <cblume@chromium.org>
Date: Mon Apr 03 09:23:44 2017

Add more WTF::PtrUtil unit tests

I recently added a unit test to cover a case that was failing.
But the other cases were not covered either.

Write some tests to cover everything in WTF::PtrUtil.

R=yutak@chromium.org
BUG= 707089 

Review-Url: https://codereview.chromium.org/2787223002
Cr-Commit-Position: refs/heads/master@{#461392}

[modify] https://crrev.com/9a254ff19df85b20fdc6b6431f9e8cf7f6912cc8/third_party/WebKit/Source/platform/wtf/PtrUtilTest.cpp

Project Member

Comment 2 by bugdroid1@chromium.org, Apr 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/976a6d5640fe93c23e6aec62d2bed2230a8fdc9b

commit 976a6d5640fe93c23e6aec62d2bed2230a8fdc9b
Author: yutak <yutak@chromium.org>
Date: Tue Apr 04 06:02:59 2017

Move PtrUtilTest.cpp to wtf_unittests.

The test was part of blink_platform_unittests temporarily, because
wtf_unittests was in the process of moving to platform/wtf/.

Now that wtf move is complete, and we can let the test belong to the right
target.

BUG= 707089 

Review-Url: https://codereview.chromium.org/2789183003
Cr-Commit-Position: refs/heads/master@{#461641}

[modify] https://crrev.com/976a6d5640fe93c23e6aec62d2bed2230a8fdc9b/third_party/WebKit/Source/platform/BUILD.gn
[modify] https://crrev.com/976a6d5640fe93c23e6aec62d2bed2230a8fdc9b/third_party/WebKit/Source/platform/wtf/BUILD.gn

Comment 3 by cblume@chromium.org, Apr 10 2017

Status: Fixed (was: Assigned)

Sign in to add a comment