New issue
Advanced search Search tips

Issue 707084 link

Starred by 2 users
Status: WontFix
Owner: ----
Closed: Sep 2017
Cc:
bunge...@chromium.org
thestig@chromium.org
drott@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug

Blocking:
issue 255186



Sign in to add a comment

pdfium uses sysroot freetype

Project Member Reported by thakis@chromium.org, Mar 30 2017 
I tried turning on a warning. It passed CQ but then broke 32-bit linux like so:

https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.linux%2FLinux_Builder__dbg__32_%2F65396%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout

In file included from ../../third_party/pdfium/core/fxge/fx_font.h:17:
In file included from ../../third_party/pdfium/core/fxge/fx_freetype.h:11:
In file included from ../../build/linux/debian_jessie_i386-sysroot/usr/include/freetype2/freetype.h:33:
../../build/linux/debian_jessie_i386-sysroot/usr/include/freetype2/config/ftconfig.h:453:5: error: 'register' storage class specifier is deprecated and incompatible with C++1z [-Werror,-Wdeprecated-register]
    register FT_Int32  result;
    ^~~~~~~~~
1 error generated.


Don't we ship our own freetype? Why does pdfium use the sysroot freetype?

Also, it's a bug that freetype uses register. I don't know if that's fixed upstream already.

Comment 1 by thestig@chromium.org, Mar 31 2017 

At one point, Linux used the bundled freetype, but we reduced our binary size by switching to the system copy. Whether we are going back to the bundled copy is undecided at the moment.

Debian Jessie is ... old, and ships FT 2.5.x.

The register use in ftconfig.h stopped in https://chromium.googlesource.com/chromium/src/third_party/freetype2/+/71330ceb50634f566abcbcdd4e21bdb962623b3d

and got moved to ftcalc.c, but https://chromium.googlesource.com/chromium/src/third_party/freetype2/+/1ec98b29ec0b9cd6ab138aac44e34562706b0016 got rid of that.

Comment 2 by thestig@chromium.org, Mar 31 2017 

There are probably other users of FreeType in Chromium somewhere, so even without PDFium, you would have hit this anyway.

Comment 3 by drott@chromium.org, Mar 31 2017

Cc: bunge...@chromium.org
FWIW, I would not mind shipping our own. We would not be exposed to security issues in system FreeTypes older than 2.7.1. After 2.6.1, the fuzzing efforts in FreeType started and found a number of issues. Plus, if we have our own, we have variable font support on Linux, and we ship what we're testing in LayoutTests.

Comment 4 by thestig@chromium.org, May 17 2017 

With  bug 274030  fixed, can we see if we are still hitting this problem?

Comment 5 by thestig@chromium.org, Sep 18 2017

Status: WontFix (was: Untriaged)
We should be using third_party/freetype. Reopen if this is still an issue.
►

Sign in to add a comment