New issue
Advanced search Search tips

Issue 707073 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Mar 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 437662



Sign in to add a comment

Add paint invalidation tests for APNG including off-screen APNG

Project Member Reported by noel@chromium.org, Mar 30 2017

Issue description

APNG support ( issue 437662 ) was added to chrome.  BitmapImage is used to drive animated images (gif, webp, apng).

We should add a paint invalidation test that shows an off-screen apng does not animate, similar to the gif test for this [1].

[1] https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/paint/invalidation/animated-gif-offscreen.html?q=animated-gif-offscreen&sq=package:chromium&dr
 

Comment 1 by noel@chromium.org, Mar 31 2017

There are other gif-related paint tests therein, so add a select few of those as well: animated-png, animated-png-background, and animated-png-offscreen.

Comment 2 by noel@chromium.org, Mar 31 2017

Status: Started (was: Available)

Comment 3 by noel@chromium.org, Mar 31 2017

Summary: Add paint invalidation tests for APNG including off-screen APNG (was: Add a paint invalidation test for an off-screen APNG image)

Comment 4 by noel@chromium.org, Mar 31 2017

Cc: chrishtr@chromium.org
Cargo cult those gif tests (a)png to https://codereview.chromium.org/2793493002 
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e3a4f13335fb6b0e38226f395c993888556b1617

commit e3a4f13335fb6b0e38226f395c993888556b1617
Author: noel <noel@chromium.org>
Date: Fri Mar 31 03:24:06 2017

Add paint invalidation tests for APNG images

Add layout tests for paint invalidation of an animated PNG (APNG)
image. Add APNG image resource derived from the GIF resource. Add
invalidation tests for the basic image case, when it's background
CSS, and when it's off-screen.

BUG= 707073 

Review-Url: https://codereview.chromium.org/2793493002
Cr-Commit-Position: refs/heads/master@{#461010}

[add] https://crrev.com/e3a4f13335fb6b0e38226f395c993888556b1617/third_party/WebKit/LayoutTests/fast/backgrounds/resources/red-green-animated.png
[add] https://crrev.com/e3a4f13335fb6b0e38226f395c993888556b1617/third_party/WebKit/LayoutTests/paint/invalidation/animated-png-background-expected.txt
[add] https://crrev.com/e3a4f13335fb6b0e38226f395c993888556b1617/third_party/WebKit/LayoutTests/paint/invalidation/animated-png-background.html
[add] https://crrev.com/e3a4f13335fb6b0e38226f395c993888556b1617/third_party/WebKit/LayoutTests/paint/invalidation/animated-png-expected.txt
[add] https://crrev.com/e3a4f13335fb6b0e38226f395c993888556b1617/third_party/WebKit/LayoutTests/paint/invalidation/animated-png-offscreen-expected.txt
[add] https://crrev.com/e3a4f13335fb6b0e38226f395c993888556b1617/third_party/WebKit/LayoutTests/paint/invalidation/animated-png-offscreen.html
[add] https://crrev.com/e3a4f13335fb6b0e38226f395c993888556b1617/third_party/WebKit/LayoutTests/paint/invalidation/animated-png.html

Comment 6 by noel@chromium.org, Mar 31 2017

Status: Fixed (was: Started)

Comment 7 Deleted

Comment 8 by noel@chromium.org, Mar 31 2017

And for completeness, I noticed that there are no such tests for animated WEBP, filed  bug 707178  about that.

Sign in to add a comment