Incorrect colorspace when video is promoted to an overlay. |
||||||||
Issue descriptionTest video https://www.youtube.com/watch?v=Es44QTJmuZ0 On my Kaby Lake system (with an sRGB monitor color profile) the video seems to have the incorrect colorspace when in an overlay vs. not. With the video-color-management feature enabled cc/ is interpreting it as BT.709 studio swing (probably correct), while without that feature it's being interpreted as BT.601 studio swing. When the video is in an actual hardware overlay then it looks more similar to the BT.601. When it's being converted to BGRA by DWM (e.g. the layer's rotated or a screenshot is taken) then it looks more like BT.709. We're using IDXGISwapChain3::SetColorSpace1 to say it's actually BT.709, so it seems like the overlay is interpreting its color space incorrectly. If I set the video to BT.601 You can see a similar issue in Edge if you load the video and resize the window - it flickers between two different sets of colors as it switches between being in an overlay and not.
,
Mar 31 2017
That should work, but may clip some colors and/or create banding in some cases. It would be a lot better if we didn't have to do that.
,
Mar 31 2017
Yeah, it's not great. This is even trickier because the same swapchain can switch between being in an overlay and not, so there's no way to make it always correct.
,
Mar 31 2017
Well, it does working (except for the clipping and banding) if I set the swapchain's color space to BT.601. So it looks like something's ignoring the color space we're setting. https://msdn.microsoft.com/en-us/library/windows/hardware/dn914477 seems to indicate that windows should be able to pass this down to the driver.
,
May 18 2017
,
Aug 11 2017
No one's complained about this that I can see, so maybe we can live with it. We could enable the FallbackBT709VideoToBT601 feature flag if this is an issue on enough systems.
,
Aug 13
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 13
=> hubbe to figure out what to do with this.
,
Dec 1
,
Dec 1
+gpu folks since hubbe@ is leaving the team.
,
Dec 1
We fixed a related bug ( issue 811118 ) earlier this year where a video would switch between user's custom color profile and srgb (or bt.709?) based on whether overlays are enabled. We were able to reproduce that bug, but haven't noticed anything like this.
,
Dec 1
There's another user reported bug open that's sounds similar to this: issue 806364
,
Dec 1
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by jbau...@chromium.org
, Mar 30 2017