Prevent offline preview reloads from showing weblite/lofi previews |
|||||||||
Issue descriptionThis should be a simple change by reloading as if it were a LoFi page in the offline preview case. This needs to be added for stable 59.
,
Mar 31 2017
2017年4月1日 01:10，"gov… via monorail" <monorail+v2.547480339@chromium.org>寫道：
,
Mar 31 2017
,
Mar 31 2017
,
Apr 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0340eb999c53a854636325ece62d211b661f67d1 commit 0340eb999c53a854636325ece62d211b661f67d1 Author: ryansturm <ryansturm@chromium.org> Date: Tue Apr 04 20:32:52 2017 Adding logic to prevent offline previews fallback to LoFi/Weblite This adds ReloadType::DISABLE_LOFI_MODE to opt outs from offline previews to prevent reloads from offline previews causing a server preview from being shown. BUG= 707060 Review-Url: https://codereview.chromium.org/2792443002 Cr-Commit-Position: refs/heads/master@{#461818} [modify] https://crrev.com/0340eb999c53a854636325ece62d211b661f67d1/chrome/browser/previews/previews_infobar_delegate.cc [modify] https://crrev.com/0340eb999c53a854636325ece62d211b661f67d1/chrome/browser/previews/previews_infobar_delegate_unittest.cc
,
Apr 4 2017
,
Apr 4 2017
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/556ea0e0bea0983ae0130f1bb7bc0533b74d8590 commit 556ea0e0bea0983ae0130f1bb7bc0533b74d8590 Author: Ryan Sturm <ryansturm@chromium.org> Date: Tue Apr 04 22:55:43 2017 Adding logic to prevent offline previews fallback to LoFi/Weblite This adds ReloadType::DISABLE_LOFI_MODE to opt outs from offline previews to prevent reloads from offline previews causing a server preview from being shown. BUG= 707060 Review-Url: https://codereview.chromium.org/2792443002 Cr-Commit-Position: refs/heads/master@{#461818} (cherry picked from commit 0340eb999c53a854636325ece62d211b661f67d1) Review-Url: https://codereview.chromium.org/2795183003 . Cr-Commit-Position: refs/branch-heads/3029@{#584} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} [modify] https://crrev.com/556ea0e0bea0983ae0130f1bb7bc0533b74d8590/chrome/browser/previews/previews_infobar_delegate.cc [modify] https://crrev.com/556ea0e0bea0983ae0130f1bb7bc0533b74d8590/chrome/browser/previews/previews_infobar_delegate_unittest.cc
,
Apr 4 2017
,
Dec 5 2017
,
Dec 5 2017
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by gov...@chromium.org
, Mar 31 2017