Subclasses of AshTest should be converted to AshTestBase. Once that is done, it should be trivial to remove AshTestImpl, WmTestBAse and WmTestHelper.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f14333c9889b233634b98673489f1268ea722034 commit f14333c9889b233634b98673489f1268ea722034 Author: sky <sky@chromium.org> Date: Tue Apr 18 22:21:01 2017 chromeos: converts DragImageViewTest to AshTestBase And removes usage of WmWindow. BUG= 707057 , 687656 TEST=covered by tests R=msw@chromium.org Review-Url: https://codereview.chromium.org/2828543003 Cr-Commit-Position: refs/heads/master@{#465393} [modify] https://crrev.com/f14333c9889b233634b98673489f1268ea722034/ash/drag_drop/drag_drop_controller.cc [modify] https://crrev.com/f14333c9889b233634b98673489f1268ea722034/ash/drag_drop/drag_image_view.cc [modify] https://crrev.com/f14333c9889b233634b98673489f1268ea722034/ash/drag_drop/drag_image_view.h [modify] https://crrev.com/f14333c9889b233634b98673489f1268ea722034/ash/drag_drop/drag_image_view_unittest.cc [modify] https://crrev.com/f14333c9889b233634b98673489f1268ea722034/ash/mus/window_manager.cc [modify] https://crrev.com/f14333c9889b233634b98673489f1268ea722034/ash/shelf/shelf_view.cc [modify] https://crrev.com/f14333c9889b233634b98673489f1268ea722034/ash/test/ash_test_base.cc [modify] https://crrev.com/f14333c9889b233634b98673489f1268ea722034/ash/test/ash_test_base.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6e5be9d31acb3b07114e88cc3d24c59e18f47be0 commit 6e5be9d31acb3b07114e88cc3d24c59e18f47be0 Author: sky <sky@chromium.org> Date: Thu Apr 27 03:24:52 2017 chromeos: converts TopLevelWindowFactoryTest to AshTestBase This makes AshTestBase::CreateTestWindow() get the logic (when in mash) that is in WmTestHelper::CreateTestWindow(). I added AshTestBase::CreateTestWindow() for migration from AshTest/WmTestBase to AshTestBase. BUG= 707057 TEST=test only changes R=jamescook@chromium.org Review-Url: https://codereview.chromium.org/2840393002 Cr-Commit-Position: refs/heads/master@{#467566} [modify] https://crrev.com/6e5be9d31acb3b07114e88cc3d24c59e18f47be0/ash/display/window_tree_host_manager_unittest.cc [modify] https://crrev.com/6e5be9d31acb3b07114e88cc3d24c59e18f47be0/ash/mus/test/wm_test_base.cc [modify] https://crrev.com/6e5be9d31acb3b07114e88cc3d24c59e18f47be0/ash/mus/test/wm_test_base.h [modify] https://crrev.com/6e5be9d31acb3b07114e88cc3d24c59e18f47be0/ash/mus/top_level_window_factory_unittest.cc [modify] https://crrev.com/6e5be9d31acb3b07114e88cc3d24c59e18f47be0/ash/test/ash_test_base.cc [modify] https://crrev.com/6e5be9d31acb3b07114e88cc3d24c59e18f47be0/ash/test/ash_test_base.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e87cbf96488f5a86d728fe23b573c25d1ea07fe2 commit e87cbf96488f5a86d728fe23b573c25d1ea07fe2 Author: sky <sky@chromium.org> Date: Fri Apr 28 01:46:05 2017 chromeos: Converts more tests to AshTestBase BUG= 707057 TEST=test only changes R=jamescook@chromium.org Review-Url: https://codereview.chromium.org/2852493002 Cr-Commit-Position: refs/heads/master@{#467811} [modify] https://crrev.com/e87cbf96488f5a86d728fe23b573c25d1ea07fe2/ash/system/brightness/tray_brightness_unittest.cc [modify] https://crrev.com/e87cbf96488f5a86d728fe23b573c25d1ea07fe2/ash/system/date/date_view_unittest.cc [modify] https://crrev.com/e87cbf96488f5a86d728fe23b573c25d1ea07fe2/ash/system/screen_security/screen_tray_item_unittest.cc [modify] https://crrev.com/e87cbf96488f5a86d728fe23b573c25d1ea07fe2/ash/wm/mru_window_tracker_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/28eafdc5710b521efa47ec4bc40ebf985ee9ff20 commit 28eafdc5710b521efa47ec4bc40ebf985ee9ff20 Author: sky <sky@chromium.org> Date: Mon May 01 18:00:07 2017 chromeos: convert remaining AshTest usage to AshTestBase And remove the now unused test related classes. BUG= 707057 TEST=test only changes R=jamescook@chromium.org Review-Url: https://codereview.chromium.org/2847283002 Cr-Commit-Position: refs/heads/master@{#468352} [modify] https://crrev.com/28eafdc5710b521efa47ec4bc40ebf985ee9ff20/ash/BUILD.gn [modify] https://crrev.com/28eafdc5710b521efa47ec4bc40ebf985ee9ff20/ash/mus/BUILD.gn [delete] https://crrev.com/7993a7f17e118c7e7eeb5762aca56db699c768e5/ash/mus/test/ash_test_impl_mus.cc [delete] https://crrev.com/7993a7f17e118c7e7eeb5762aca56db699c768e5/ash/mus/test/ash_test_impl_mus.h [delete] https://crrev.com/7993a7f17e118c7e7eeb5762aca56db699c768e5/ash/mus/test/wm_test_base.cc [delete] https://crrev.com/7993a7f17e118c7e7eeb5762aca56db699c768e5/ash/mus/test/wm_test_base.h [delete] https://crrev.com/7993a7f17e118c7e7eeb5762aca56db699c768e5/ash/mus/test/wm_test_helper.cc [delete] https://crrev.com/7993a7f17e118c7e7eeb5762aca56db699c768e5/ash/mus/test/wm_test_helper.h [modify] https://crrev.com/28eafdc5710b521efa47ec4bc40ebf985ee9ff20/ash/mus/top_level_window_factory_unittest.cc [modify] https://crrev.com/28eafdc5710b521efa47ec4bc40ebf985ee9ff20/ash/mus/window_manager.h [modify] https://crrev.com/28eafdc5710b521efa47ec4bc40ebf985ee9ff20/ash/mus/window_manager_application.h [modify] https://crrev.com/28eafdc5710b521efa47ec4bc40ebf985ee9ff20/ash/mus_property_mirror_ash_unittest.cc [modify] https://crrev.com/28eafdc5710b521efa47ec4bc40ebf985ee9ff20/ash/system/audio/tray_audio_unittest.cc [modify] https://crrev.com/28eafdc5710b521efa47ec4bc40ebf985ee9ff20/ash/system/update/tray_update_unittest.cc [modify] https://crrev.com/28eafdc5710b521efa47ec4bc40ebf985ee9ff20/ash/test/BUILD.gn [delete] https://crrev.com/7993a7f17e118c7e7eeb5762aca56db699c768e5/ash/test/ash_test.cc [delete] https://crrev.com/7993a7f17e118c7e7eeb5762aca56db699c768e5/ash/test/ash_test.h [modify] https://crrev.com/28eafdc5710b521efa47ec4bc40ebf985ee9ff20/ash/test/ash_test_base.cc [modify] https://crrev.com/28eafdc5710b521efa47ec4bc40ebf985ee9ff20/ash/test/ash_test_base.h [delete] https://crrev.com/7993a7f17e118c7e7eeb5762aca56db699c768e5/ash/test/ash_test_impl.h [delete] https://crrev.com/7993a7f17e118c7e7eeb5762aca56db699c768e5/ash/test/ash_test_impl_aura.cc [delete] https://crrev.com/7993a7f17e118c7e7eeb5762aca56db699c768e5/ash/test/ash_test_impl_aura.h [modify] https://crrev.com/28eafdc5710b521efa47ec4bc40ebf985ee9ff20/ash/window_user_data_unittest.cc [modify] https://crrev.com/28eafdc5710b521efa47ec4bc40ebf985ee9ff20/ash/wm/workspace/workspace_layout_manager_keyboard_unittest.cc [modify] https://crrev.com/28eafdc5710b521efa47ec4bc40ebf985ee9ff20/ash/wm/workspace/workspace_layout_manager_unittest.cc [delete] https://crrev.com/7993a7f17e118c7e7eeb5762aca56db699c768e5/ash/wm_window_unittest.cc
Comment 1 by sky@chromium.org
, Apr 18 2017