powerd should log initial tablet mode state |
|||||||
Issue descriptionpowerd should log something when the system is in tablet mode at startup. It already does so for the lid switch. Without this, it can be hard to determine why powerd is inhibiting or not inhibiting devices.
,
Mar 31 2017
Requesting a merge of this trivial logging change to M58 to make it easier to track down input device issues.
,
Mar 31 2017
+bernie
,
Mar 31 2017
,
Mar 31 2017
,
Mar 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/23c33e9692bea1ee109891ceb04b4aac88a43f37 commit 23c33e9692bea1ee109891ceb04b4aac88a43f37 Author: Daniel Erat <derat@chromium.org> Date: Fri Mar 31 18:29:00 2017 power: Log when in tablet mode at startup. Make powerd log "Tablet mode enabled at startup" if the tablet mode switch reports that the system is already in tablet mode when powerd starts. I think that powerd used to log this, but it doesn't anymore -- only the lid switch gets this treatment. Without it, the logs are super-confusing. Along the same lines, make InputDeviceController log mode changes and remove an outdated TODO about tracking tablet mode. BUG= chromium:707048 TEST=none Change-Id: Idcaedfa9ab26b5d26852a36eb785a7e487577a6b Reviewed-on: https://chromium-review.googlesource.com/463871 Commit-Ready: Dan Erat <derat@chromium.org> Tested-by: Dan Erat <derat@chromium.org> Reviewed-by: Aaron Durbin <adurbin@chromium.org> (cherry picked from commit dae99f9133a1c13fc2336bf8421426bc3869ba94) Reviewed-on: https://chromium-review.googlesource.com/465408 Reviewed-by: Dan Erat <derat@chromium.org> [modify] https://crrev.com/23c33e9692bea1ee109891ceb04b4aac88a43f37/power_manager/powerd/daemon.cc [modify] https://crrev.com/23c33e9692bea1ee109891ceb04b4aac88a43f37/power_manager/powerd/policy/input_device_controller.cc [modify] https://crrev.com/23c33e9692bea1ee109891ceb04b4aac88a43f37/power_manager/powerd/policy/input_device_controller.h
,
Apr 4 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 4 2017
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by bugdroid1@chromium.org
, Mar 31 2017