New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 707048 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

powerd should log initial tablet mode state

Project Member Reported by derat@chromium.org, Mar 30 2017

Issue description

powerd should log something when the system is in tablet mode at startup. It already does so for the lid switch. Without this, it can be hard to determine why powerd is inhibiting or not inhibiting devices.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/dae99f9133a1c13fc2336bf8421426bc3869ba94

commit dae99f9133a1c13fc2336bf8421426bc3869ba94
Author: Daniel Erat <derat@chromium.org>
Date: Fri Mar 31 04:21:58 2017

power: Log when in tablet mode at startup.

Make powerd log "Tablet mode enabled at startup" if the
tablet mode switch reports that the system is already in
tablet mode when powerd starts. I think that powerd used to
log this, but it doesn't anymore -- only the lid switch gets
this treatment. Without it, the logs are super-confusing.

Along the same lines, make InputDeviceController log mode
changes and remove an outdated TODO about tracking tablet
mode.

BUG= chromium:707048 
TEST=none

Change-Id: Idcaedfa9ab26b5d26852a36eb785a7e487577a6b
Reviewed-on: https://chromium-review.googlesource.com/463871
Commit-Ready: Dan Erat <derat@chromium.org>
Tested-by: Dan Erat <derat@chromium.org>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>

[modify] https://crrev.com/dae99f9133a1c13fc2336bf8421426bc3869ba94/power_manager/powerd/daemon.cc
[modify] https://crrev.com/dae99f9133a1c13fc2336bf8421426bc3869ba94/power_manager/powerd/policy/input_device_controller.cc
[modify] https://crrev.com/dae99f9133a1c13fc2336bf8421426bc3869ba94/power_manager/powerd/policy/input_device_controller.h

Comment 2 by derat@chromium.org, Mar 31 2017

Labels: Merge-Request-58
Requesting a merge of this trivial logging change to M58 to make it easier to track down input device issues.

Comment 3 by bleung@chromium.org, Mar 31 2017

Cc: bhthompson@chromium.org
+bernie
Labels: -Merge-Request-58 Merge-Approved-58

Comment 5 by derat@chromium.org, Mar 31 2017

Status: Verified (was: Started)
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 31 2017

Labels: merge-merged-release-R58-9334.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/23c33e9692bea1ee109891ceb04b4aac88a43f37

commit 23c33e9692bea1ee109891ceb04b4aac88a43f37
Author: Daniel Erat <derat@chromium.org>
Date: Fri Mar 31 18:29:00 2017

power: Log when in tablet mode at startup.

Make powerd log "Tablet mode enabled at startup" if the
tablet mode switch reports that the system is already in
tablet mode when powerd starts. I think that powerd used to
log this, but it doesn't anymore -- only the lid switch gets
this treatment. Without it, the logs are super-confusing.

Along the same lines, make InputDeviceController log mode
changes and remove an outdated TODO about tracking tablet
mode.

BUG= chromium:707048 
TEST=none

Change-Id: Idcaedfa9ab26b5d26852a36eb785a7e487577a6b
Reviewed-on: https://chromium-review.googlesource.com/463871
Commit-Ready: Dan Erat <derat@chromium.org>
Tested-by: Dan Erat <derat@chromium.org>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
(cherry picked from commit dae99f9133a1c13fc2336bf8421426bc3869ba94)
Reviewed-on: https://chromium-review.googlesource.com/465408
Reviewed-by: Dan Erat <derat@chromium.org>

[modify] https://crrev.com/23c33e9692bea1ee109891ceb04b4aac88a43f37/power_manager/powerd/daemon.cc
[modify] https://crrev.com/23c33e9692bea1ee109891ceb04b4aac88a43f37/power_manager/powerd/policy/input_device_controller.cc
[modify] https://crrev.com/23c33e9692bea1ee109891ceb04b4aac88a43f37/power_manager/powerd/policy/input_device_controller.h

Project Member

Comment 7 by sheriffbot@chromium.org, Apr 4 2017

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 8 by derat@chromium.org, Apr 4 2017

Labels: -Merge-Approved-58

Sign in to add a comment