roll_closure_compiler doesn't work with Java and JDK 1.8 |
|||
Issue descriptionUserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/57.0.2987.110 Safari/537.36 Steps to reproduce the problem: 1. Install Java 1.8 2. Run chromium/src/third_party/closure_compiler/roll_closure_compiler 3. Get an error complaining that the script requires Java 1.7 If the JDK doesn't match the same will happen, just with the JDK What is the expected behavior? 1.7 and above should be okay. What went wrong? The script checks for 1.7 vs 1.7 or above Did this work before? N/A Chrome version: 57.0.2987.110 Channel: n/a OS Version: Flash Version:
,
Mar 30 2017
,
Mar 31 2017
FYI I tried this yesterday at https://codereview.chromium.org/2786793002 (patch2). Eventually I reverted to 1.7 again, since I was not sure if a jar binary built with java 1.7, will be runnable by java 1.8 (and I don't think the bots have 1.8).
,
Mar 31 2017
Eh, I meant the opposite *binary built with java 1.8, will be runnable by java 1.7. Anyway.
,
Apr 3 2017
Were the errors that you saw in the builds due to Java versions? All the Maven XML files specify -source 1.7 -target 1.7 so whatever is produced should work with 1.7.
,
Apr 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/de6533cf19916679011872eeb9d359ce857c5308 commit de6533cf19916679011872eeb9d359ce857c5308 Author: drcrash <drcrash@chromium.org> Date: Tue Apr 04 18:25:40 2017 New checks for Java version against Maven files. Fix version check of Java and JDK to be 1.7 or above. BUG= 707043 TEST=manual CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2796033003 Cr-Commit-Position: refs/heads/master@{#461776} [modify] https://crrev.com/de6533cf19916679011872eeb9d359ce857c5308/third_party/closure_compiler/roll_closure_compiler
,
Apr 24 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by drcrash@chromium.org
, Mar 30 2017EstimatedDays: 1
Owner: drcrash@chromium.org
Status: Started (was: Unconfirmed)