Replace chrome_test_util::WebViewContainingText with something like [ChromeEarlGrey waitForWebViewContainingText]
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ee4557b858b9b19eeab13da386f15e31e27718e6 commit ee4557b858b9b19eeab13da386f15e31e27718e6 Author: baxley <baxley@chromium.org> Date: Mon Jun 12 18:21:48 2017 Create ChromeEarlGrey waitForWebViewContainingText. Matchers should not wait, so this is a replacement. This replaces most uses of chrome_test_util::WebViewContainingText. There are a few left over that are dependent upon having a method that waits for the absence of a test. BUG= 707009 Review-Url: https://codereview.chromium.org/2798773002 Cr-Commit-Position: refs/heads/master@{#478687} [modify] https://crrev.com/ee4557b858b9b19eeab13da386f15e31e27718e6/ios/chrome/browser/autofill/form_input_egtest.mm [modify] https://crrev.com/ee4557b858b9b19eeab13da386f15e31e27718e6/ios/chrome/browser/context_menu/context_menu_egtest.mm [modify] https://crrev.com/ee4557b858b9b19eeab13da386f15e31e27718e6/ios/chrome/browser/metrics/tab_usage_recorder_egtest.mm [modify] https://crrev.com/ee4557b858b9b19eeab13da386f15e31e27718e6/ios/chrome/browser/translate/translate_egtest.mm [modify] https://crrev.com/ee4557b858b9b19eeab13da386f15e31e27718e6/ios/chrome/browser/ui/browser_view_controller_egtest.mm [modify] https://crrev.com/ee4557b858b9b19eeab13da386f15e31e27718e6/ios/chrome/browser/ui/dialogs/BUILD.gn [modify] https://crrev.com/ee4557b858b9b19eeab13da386f15e31e27718e6/ios/chrome/browser/ui/dialogs/javascript_dialog_egtest.mm [modify] https://crrev.com/ee4557b858b9b19eeab13da386f15e31e27718e6/ios/chrome/browser/ui/external_url_error_page_egtest.mm [modify] https://crrev.com/ee4557b858b9b19eeab13da386f15e31e27718e6/ios/chrome/browser/ui/find_bar/find_in_page_egtest.mm [modify] https://crrev.com/ee4557b858b9b19eeab13da386f15e31e27718e6/ios/chrome/browser/ui/fullscreen_egtest.mm [modify] https://crrev.com/ee4557b858b9b19eeab13da386f15e31e27718e6/ios/chrome/browser/ui/history/history_ui_egtest.mm [modify] https://crrev.com/ee4557b858b9b19eeab13da386f15e31e27718e6/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_panel_controller_egtest.mm [modify] https://crrev.com/ee4557b858b9b19eeab13da386f15e31e27718e6/ios/chrome/browser/ui/print/print_controller_egtest.mm [modify] https://crrev.com/ee4557b858b9b19eeab13da386f15e31e27718e6/ios/chrome/browser/ui/qr_scanner/qr_scanner_view_controller_egtest.mm [modify] https://crrev.com/ee4557b858b9b19eeab13da386f15e31e27718e6/ios/chrome/browser/ui/reading_list/reading_list_egtest.mm [modify] https://crrev.com/ee4557b858b9b19eeab13da386f15e31e27718e6/ios/chrome/browser/ui/settings/settings_egtest.mm [modify] https://crrev.com/ee4557b858b9b19eeab13da386f15e31e27718e6/ios/chrome/browser/ui/toolbar/toolbar_egtest.mm [modify] https://crrev.com/ee4557b858b9b19eeab13da386f15e31e27718e6/ios/chrome/browser/ui/webui/web_ui_egtest.mm [modify] https://crrev.com/ee4557b858b9b19eeab13da386f15e31e27718e6/ios/chrome/browser/web/browsing_egtest.mm [modify] https://crrev.com/ee4557b858b9b19eeab13da386f15e31e27718e6/ios/chrome/browser/web/browsing_prevent_default_egtest.mm [modify] https://crrev.com/ee4557b858b9b19eeab13da386f15e31e27718e6/ios/chrome/browser/web/cache_egtest.mm [modify] https://crrev.com/ee4557b858b9b19eeab13da386f15e31e27718e6/ios/chrome/browser/web/child_window_open_by_dom_egtest.mm [modify] https://crrev.com/ee4557b858b9b19eeab13da386f15e31e27718e6/ios/chrome/browser/web/http_auth_egtest.mm [modify] https://crrev.com/ee4557b858b9b19eeab13da386f15e31e27718e6/ios/chrome/browser/web/navigation_egtest.mm [modify] https://crrev.com/ee4557b858b9b19eeab13da386f15e31e27718e6/ios/chrome/browser/web/progress_indicator_egtest.mm [modify] https://crrev.com/ee4557b858b9b19eeab13da386f15e31e27718e6/ios/chrome/browser/web/push_and_replace_state_navigation_egtest.mm [modify] https://crrev.com/ee4557b858b9b19eeab13da386f15e31e27718e6/ios/chrome/browser/web/stop_loading_egtest.mm [modify] https://crrev.com/ee4557b858b9b19eeab13da386f15e31e27718e6/ios/chrome/browser/web/visible_url_egtest.mm [modify] https://crrev.com/ee4557b858b9b19eeab13da386f15e31e27718e6/ios/chrome/browser/web/window_open_by_dom_egtest.mm [modify] https://crrev.com/ee4557b858b9b19eeab13da386f15e31e27718e6/ios/chrome/test/earl_grey/chrome_earl_grey.h [modify] https://crrev.com/ee4557b858b9b19eeab13da386f15e31e27718e6/ios/chrome/test/earl_grey/chrome_earl_grey.mm [modify] https://crrev.com/ee4557b858b9b19eeab13da386f15e31e27718e6/ios/chrome/test/earl_grey/device_check_egtest.mm [modify] https://crrev.com/ee4557b858b9b19eeab13da386f15e31e27718e6/ios/web/public/test/BUILD.gn [add] https://crrev.com/ee4557b858b9b19eeab13da386f15e31e27718e6/ios/web/public/test/web_view_content_test_util.h [add] https://crrev.com/ee4557b858b9b19eeab13da386f15e31e27718e6/ios/web/public/test/web_view_content_test_util.mm [modify] https://crrev.com/ee4557b858b9b19eeab13da386f15e31e27718e6/ios/web/shell/test/context_menu_egtest.mm [modify] https://crrev.com/ee4557b858b9b19eeab13da386f15e31e27718e6/ios/web/shell/test/earl_grey/shell_earl_grey.h [modify] https://crrev.com/ee4557b858b9b19eeab13da386f15e31e27718e6/ios/web/shell/test/earl_grey/shell_earl_grey.mm [modify] https://crrev.com/ee4557b858b9b19eeab13da386f15e31e27718e6/ios/web/shell/test/earl_grey/web_shell_test_case.mm [modify] https://crrev.com/ee4557b858b9b19eeab13da386f15e31e27718e6/ios/web/shell/test/meta_tags_egtest.mm [modify] https://crrev.com/ee4557b858b9b19eeab13da386f15e31e27718e6/ios/web/shell/test/navigation_egtest.mm [modify] https://crrev.com/ee4557b858b9b19eeab13da386f15e31e27718e6/ios/web/shell/test/plugin_placeholder_egtest.mm [modify] https://crrev.com/ee4557b858b9b19eeab13da386f15e31e27718e6/ios/web/shell/test/redirect_egtest.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6c9a057d44bf493849506a2c485489fe5d4cba50 commit 6c9a057d44bf493849506a2c485489fe5d4cba50 Author: Mike Baxley <baxley@chromium.org> Date: Wed Jul 05 15:37:23 2017 Replace use of WebViewContainingText matcher in progress indicator test. [ChromeEarlGrey waitForWebViewContainingText:] should be used instead of a matcher that waits. Bug: 707009 Change-Id: I9cf5b2a1bdf701572b00a64485492a6af31494b5 Reviewed-on: https://chromium-review.googlesource.com/558974 Reviewed-by: Eugene But <eugenebut@chromium.org> Commit-Queue: Mike Baxley <baxley@chromium.org> Cr-Commit-Position: refs/heads/master@{#484283} [modify] https://crrev.com/6c9a057d44bf493849506a2c485489fe5d4cba50/ios/chrome/browser/web/progress_indicator_egtest.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d010336cd3d39d39a5500193d4bbf86ed49bc3d5 commit d010336cd3d39d39a5500193d4bbf86ed49bc3d5 Author: Mike Baxley <baxley@chromium.org> Date: Fri Jul 07 17:50:25 2017 Delete chrome_test_util::WebViewContainingText(). This matcher has been replaced by [ChromeEarlGrey waitForWebViewContainingText:]. Bug: 707009 Change-Id: I660a44b6e802c6c5c3b6b835d7f69aa201453f29 Reviewed-on: https://chromium-review.googlesource.com/558975 Reviewed-by: Eugene But <eugenebut@chromium.org> Commit-Queue: Mike Baxley <baxley@chromium.org> Cr-Commit-Position: refs/heads/master@{#484978} [modify] https://crrev.com/d010336cd3d39d39a5500193d4bbf86ed49bc3d5/ios/chrome/browser/ui/reading_list/reading_list_egtest.mm [modify] https://crrev.com/d010336cd3d39d39a5500193d4bbf86ed49bc3d5/ios/chrome/browser/ui/tools_menu/request_desktop_mobile_site_egtest.mm [modify] https://crrev.com/d010336cd3d39d39a5500193d4bbf86ed49bc3d5/ios/chrome/browser/web/cache_egtest.mm [modify] https://crrev.com/d010336cd3d39d39a5500193d4bbf86ed49bc3d5/ios/chrome/browser/web/forms_egtest.mm [modify] https://crrev.com/d010336cd3d39d39a5500193d4bbf86ed49bc3d5/ios/chrome/test/earl_grey/chrome_matchers.h [modify] https://crrev.com/d010336cd3d39d39a5500193d4bbf86ed49bc3d5/ios/chrome/test/earl_grey/chrome_matchers.mm [modify] https://crrev.com/d010336cd3d39d39a5500193d4bbf86ed49bc3d5/ios/chrome/test/earl_grey/device_check_egtest.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/abb84b429ed98f4091a7a5e9d18e85ae745ffdca commit abb84b429ed98f4091a7a5e9d18e85ae745ffdca Author: Mike Baxley <baxley@chromium.org> Date: Mon Aug 07 20:30:49 2017 Remove the WaitForWebViewContainingText matcher. This is no longer used by any of our tests. Bug: 707009 Change-Id: Ifef26edad0ba451c7ffdd3f9e022371b145a4072 Reviewed-on: https://chromium-review.googlesource.com/602621 Reviewed-by: Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Mike Baxley <baxley@chromium.org> Cr-Commit-Position: refs/heads/master@{#492393} [modify] https://crrev.com/abb84b429ed98f4091a7a5e9d18e85ae745ffdca/ios/web/public/test/earl_grey/web_view_matchers.h [modify] https://crrev.com/abb84b429ed98f4091a7a5e9d18e85ae745ffdca/ios/web/public/test/earl_grey/web_view_matchers.mm [modify] https://crrev.com/abb84b429ed98f4091a7a5e9d18e85ae745ffdca/ios/web/shell/test/earl_grey/shell_matchers.h [modify] https://crrev.com/abb84b429ed98f4091a7a5e9d18e85ae745ffdca/ios/web/shell/test/earl_grey/shell_matchers.mm
Comment 1 by bugdroid1@chromium.org
, Jun 12 2017