The crushed sprite was designed to drive CTR but we never saw a noticeable uptick. The animated logo is adding unnecessary code complexity and APK size (for the assets), so the team has agreed to sunset the feature.
In-flight CL: https://codereview.chromium.org/2798123002
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7ce5ab6e1b8c7f699c838b8086d42ed1866d21ba commit 7ce5ab6e1b8c7f699c838b8086d42ed1866d21ba Author: twellington <twellington@chromium.org> Date: Fri Apr 07 14:59:47 2017 Remove crushed sprite resource and layer Crushed sprite resources and layers were only used for Contextual Search. CS no longer has a use for a the animated sprite, so this removes the crushed sprite resources and layers and replaces the CS use with a static icon. BUG= 707001 Review-Url: https://codereview.chromium.org/2798123002 Cr-Commit-Position: refs/heads/master@{#462861} [modify] https://crrev.com/7ce5ab6e1b8c7f699c838b8086d42ed1866d21ba/build/android/lint/suppressions.xml [modify] https://crrev.com/7ce5ab6e1b8c7f699c838b8086d42ed1866d21ba/chrome/android/BUILD.gn [delete] https://crrev.com/e7274aef78e201e05c8fbcaa160717f3bdec968b/chrome/android/java/res/drawable-mdpi/google_icon_sprite.png [delete] https://crrev.com/e7274aef78e201e05c8fbcaa160717f3bdec968b/chrome/android/java/res/drawable-xxhdpi/google_icon_sprite.png [modify] https://crrev.com/7ce5ab6e1b8c7f699c838b8086d42ed1866d21ba/chrome/android/java/res/layout/contextual_search_quick_action_icon_view.xml [delete] https://crrev.com/e7274aef78e201e05c8fbcaa160717f3bdec968b/chrome/android/java/res/raw/google_icon_sprite.json [modify] https://crrev.com/7ce5ab6e1b8c7f699c838b8086d42ed1866d21ba/chrome/android/java/res/values/dimens.xml [modify] https://crrev.com/7ce5ab6e1b8c7f699c838b8086d42ed1866d21ba/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchBarControl.java [delete] https://crrev.com/e7274aef78e201e05c8fbcaa160717f3bdec968b/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchIconSpriteControl.java [modify] https://crrev.com/7ce5ab6e1b8c7f699c838b8086d42ed1866d21ba/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchImageControl.java [modify] https://crrev.com/7ce5ab6e1b8c7f699c838b8086d42ed1866d21ba/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanel.java [modify] https://crrev.com/7ce5ab6e1b8c7f699c838b8086d42ed1866d21ba/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanelMetrics.java [modify] https://crrev.com/7ce5ab6e1b8c7f699c838b8086d42ed1866d21ba/chrome/android/java/src/org/chromium/chrome/browser/compositor/scene_layer/ContextualSearchSceneLayer.java [modify] https://crrev.com/7ce5ab6e1b8c7f699c838b8086d42ed1866d21ba/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java [modify] https://crrev.com/7ce5ab6e1b8c7f699c838b8086d42ed1866d21ba/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchUma.java [modify] https://crrev.com/7ce5ab6e1b8c7f699c838b8086d42ed1866d21ba/chrome/android/java_sources.gni [modify] https://crrev.com/7ce5ab6e1b8c7f699c838b8086d42ed1866d21ba/chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java [modify] https://crrev.com/7ce5ab6e1b8c7f699c838b8086d42ed1866d21ba/chrome/browser/BUILD.gn [modify] https://crrev.com/7ce5ab6e1b8c7f699c838b8086d42ed1866d21ba/chrome/browser/android/compositor/OWNERS [modify] https://crrev.com/7ce5ab6e1b8c7f699c838b8086d42ed1866d21ba/chrome/browser/android/compositor/layer/contextual_search_layer.cc [modify] https://crrev.com/7ce5ab6e1b8c7f699c838b8086d42ed1866d21ba/chrome/browser/android/compositor/layer/contextual_search_layer.h [delete] https://crrev.com/e7274aef78e201e05c8fbcaa160717f3bdec968b/chrome/browser/android/compositor/layer/crushed_sprite_layer.cc [delete] https://crrev.com/e7274aef78e201e05c8fbcaa160717f3bdec968b/chrome/browser/android/compositor/layer/crushed_sprite_layer.h [modify] https://crrev.com/7ce5ab6e1b8c7f699c838b8086d42ed1866d21ba/chrome/browser/android/compositor/layer/overlay_panel_layer.cc [modify] https://crrev.com/7ce5ab6e1b8c7f699c838b8086d42ed1866d21ba/chrome/browser/android/compositor/scene_layer/contextual_search_scene_layer.cc [modify] https://crrev.com/7ce5ab6e1b8c7f699c838b8086d42ed1866d21ba/chrome/browser/android/compositor/scene_layer/contextual_search_scene_layer.h [modify] https://crrev.com/7ce5ab6e1b8c7f699c838b8086d42ed1866d21ba/tools/metrics/histograms/histograms.xml [modify] https://crrev.com/7ce5ab6e1b8c7f699c838b8086d42ed1866d21ba/ui/android/BUILD.gn [modify] https://crrev.com/7ce5ab6e1b8c7f699c838b8086d42ed1866d21ba/ui/android/java/src/org/chromium/ui/resources/ResourceManager.java [delete] https://crrev.com/e7274aef78e201e05c8fbcaa160717f3bdec968b/ui/android/java/src/org/chromium/ui/resources/sprites/CrushedSpriteResource.java [delete] https://crrev.com/e7274aef78e201e05c8fbcaa160717f3bdec968b/ui/android/java/src/org/chromium/ui/resources/sprites/CrushedSpriteResourceLoader.java [delete] https://crrev.com/e7274aef78e201e05c8fbcaa160717f3bdec968b/ui/android/javatests/src/org/chromium/ui/resources/sprites/CrushedSpriteResourceTest.java [delete] https://crrev.com/e7274aef78e201e05c8fbcaa160717f3bdec968b/ui/android/resources/crushed_sprite_resource.cc [delete] https://crrev.com/e7274aef78e201e05c8fbcaa160717f3bdec968b/ui/android/resources/crushed_sprite_resource.h [modify] https://crrev.com/7ce5ab6e1b8c7f699c838b8086d42ed1866d21ba/ui/android/resources/resource_manager.h [modify] https://crrev.com/7ce5ab6e1b8c7f699c838b8086d42ed1866d21ba/ui/android/resources/resource_manager_impl.cc [modify] https://crrev.com/7ce5ab6e1b8c7f699c838b8086d42ed1866d21ba/ui/android/resources/resource_manager_impl.h [modify] https://crrev.com/7ce5ab6e1b8c7f699c838b8086d42ed1866d21ba/ui/android/resources/resource_manager_impl_unittest.cc
Comment 1 by twelling...@chromium.org
, Apr 5 201716.8 MB
16.8 MB Download