New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 706956 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Restrict background services for cache invalidation only on O.

Project Member Reported by khushals...@chromium.org, Mar 30 2017

Issue description

The current logic uses BuildInfo.isGreaterThanN which is still true for certain N builds. Using this logic to gate background services will prevent us from stopping invalidation sync on N.
 

Comment 1 by zea@chromium.org, Mar 30 2017

Components: Services>Sync
Labels: ReleaseBlock-Stable M-58 Performance-Power

Comment 2 by zea@chromium.org, Mar 30 2017

Components: Services>Invalidation
Labels: Merge-Request-58
This is the change to merge btw: https://codereview.chromium.org/2790703002/
Labels: -Merge-Request-58 Merge-Approved-58
Merge approved for M58 branch 3029.
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 31 2017

Labels: -merge-approved-58 merge-merged-3029
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9266031a6c59f20cdab0e500ecc742a31695548a

commit 9266031a6c59f20cdab0e500ecc742a31695548a
Author: Khushal <khushalsagar@google.com>
Date: Fri Mar 31 21:30:50 2017

cache_invalidation: Restrict background services only on O.

Starting/Stoping the invalidation client requires starting a service
which should be gated on O builds only. Since the current check uses
isGreaterThanN, which is still true for certain N builds, use
isGreaterThanO instead.

BUG= 706956 

Review-Url: https://codereview.chromium.org/2790703002
Cr-Commit-Position: refs/heads/master@{#460864}
(cherry picked from commit faa4d68dd2fec796031ce483ef8aed4929bef34c)

Review-Url: https://codereview.chromium.org/2792683002 .
Cr-Commit-Position: refs/branch-heads/3029@{#519}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/9266031a6c59f20cdab0e500ecc742a31695548a/chrome/android/java/src/org/chromium/chrome/browser/invalidation/InvalidationController.java
[modify] https://crrev.com/9266031a6c59f20cdab0e500ecc742a31695548a/components/invalidation/impl/android/java/src/org/chromium/components/invalidation/InvalidationClientService.java
[modify] https://crrev.com/9266031a6c59f20cdab0e500ecc742a31695548a/components/invalidation/impl/android/java/src/org/chromium/components/invalidation/InvalidationService.java

Status: Fixed (was: Assigned)

Comment 8 by zea@chromium.org, Mar 31 2017

Thanks for the quick fix Khushal!

Comment 9 by zea@chromium.org, Apr 3 2017

 Issue 707799  has been merged into this issue.

Sign in to add a comment