New issue
Advanced search Search tips

Issue 706950 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Cups Manufacturer selection should clear model selection

Project Member Reported by justincarlson@chromium.org, Mar 30 2017

Issue description

When adding a cups printer manually, the normal flow is

select manufacturer
select model

click add.

However, if the user does this

select manufacturer
select model
select *different* manufacturer

they end up preserving the model value, which can lead to strange combinations (for example, the "Fujitsu HP Color LaserJet").  

Presumably we should clear the model selection if the manufacturer selection changes.
 

Comment 1 by x...@chromium.org, May 9 2017

Owner: x...@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, May 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0e64a9ca93f8ec7cb3ef6625903bf9a2e96f73bf

commit 0e64a9ca93f8ec7cb3ef6625903bf9a2e96f73bf
Author: xdai <xdai@chromium.org>
Date: Wed May 10 18:23:54 2017

[CUPS] Change manufacturer selection should clear model selection in the dropdown list.

BUG= 706950 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2868723005
Cr-Commit-Position: refs/heads/master@{#470647}

[modify] https://crrev.com/0e64a9ca93f8ec7cb3ef6625903bf9a2e96f73bf/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.js
[modify] https://crrev.com/0e64a9ca93f8ec7cb3ef6625903bf9a2e96f73bf/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog_util.html

Comment 3 by x...@chromium.org, May 10 2017

Status: Fixed (was: Available)

Sign in to add a comment