New issue
Advanced search Search tips

Issue 706942 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Proj-Servicification

Blocking:
issue 598073
issue 706030



Sign in to add a comment

Remove URLRequestJobFactory::IsHandledURL.

Project Member Reported by mmenke@chromium.org, Mar 30 2017

Issue description

In practice, it's just a combination of GURL::is_valid() and URLRequestJobFactory::IsHandledProtocol(GURL::is_scheme()).  While removing it doesn't get us a great deal, it does make its impact on servification a bit clearer.  It's possible we can remove the method entirely in the future.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1918ae78a8154c4dfc31fd238f9a00c53bbd96fd

commit 1918ae78a8154c4dfc31fd238f9a00c53bbd96fd
Author: mmenke <mmenke@chromium.org>
Date: Mon Apr 03 20:10:20 2017

Remove URLRequestJobFactory::IsHandledURL.

In practice, this was just a combination of GURL::is_valid() and
URLRequestJobFactory::IsHandledProtocol(GURL::is_scheme()).

This is just motivated by a desire to simplify the knobs exposed by
the network stack, for servicification.  This does add a number of
GURL::is_valid() checks, but I suspect most of them will go away, as we
adapt the launch externally handled protocol path.

BUG= 706942 

Review-Url: https://codereview.chromium.org/2783343002
Cr-Commit-Position: refs/heads/master@{#461518}

[modify] https://crrev.com/1918ae78a8154c4dfc31fd238f9a00c53bbd96fd/android_webview/browser/net/aw_url_request_job_factory.cc
[modify] https://crrev.com/1918ae78a8154c4dfc31fd238f9a00c53bbd96fd/android_webview/browser/net/aw_url_request_job_factory.h
[modify] https://crrev.com/1918ae78a8154c4dfc31fd238f9a00c53bbd96fd/chrome/browser/chromeos/fileapi/external_file_url_request_job_unittest.cc
[modify] https://crrev.com/1918ae78a8154c4dfc31fd238f9a00c53bbd96fd/chrome/browser/custom_handlers/protocol_handler_registry.cc
[modify] https://crrev.com/1918ae78a8154c4dfc31fd238f9a00c53bbd96fd/chrome/browser/custom_handlers/protocol_handler_registry.h
[modify] https://crrev.com/1918ae78a8154c4dfc31fd238f9a00c53bbd96fd/chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc
[modify] https://crrev.com/1918ae78a8154c4dfc31fd238f9a00c53bbd96fd/chrome/browser/predictors/resource_prefetch_predictor_unittest.cc
[modify] https://crrev.com/1918ae78a8154c4dfc31fd238f9a00c53bbd96fd/content/browser/android/url_request_content_job_unittest.cc
[modify] https://crrev.com/1918ae78a8154c4dfc31fd238f9a00c53bbd96fd/content/browser/appcache/appcache_request_handler_unittest.cc
[modify] https://crrev.com/1918ae78a8154c4dfc31fd238f9a00c53bbd96fd/content/browser/appcache/appcache_url_request_job_unittest.cc
[modify] https://crrev.com/1918ae78a8154c4dfc31fd238f9a00c53bbd96fd/content/browser/download/download_manager_impl.cc
[modify] https://crrev.com/1918ae78a8154c4dfc31fd238f9a00c53bbd96fd/content/browser/download/save_file_manager.cc
[modify] https://crrev.com/1918ae78a8154c4dfc31fd238f9a00c53bbd96fd/content/browser/fileapi/file_system_dir_url_request_job_unittest.cc
[modify] https://crrev.com/1918ae78a8154c4dfc31fd238f9a00c53bbd96fd/content/browser/fileapi/file_system_url_request_job_unittest.cc
[modify] https://crrev.com/1918ae78a8154c4dfc31fd238f9a00c53bbd96fd/content/browser/fileapi/file_writer_delegate_unittest.cc
[modify] https://crrev.com/1918ae78a8154c4dfc31fd238f9a00c53bbd96fd/content/browser/loader/navigation_resource_throttle.cc
[modify] https://crrev.com/1918ae78a8154c4dfc31fd238f9a00c53bbd96fd/content/browser/loader/resource_dispatcher_host_impl.cc
[modify] https://crrev.com/1918ae78a8154c4dfc31fd238f9a00c53bbd96fd/content/browser/loader/resource_dispatcher_host_unittest.cc
[modify] https://crrev.com/1918ae78a8154c4dfc31fd238f9a00c53bbd96fd/net/sdch/sdch_owner_unittest.cc
[modify] https://crrev.com/1918ae78a8154c4dfc31fd238f9a00c53bbd96fd/net/url_request/url_request_file_dir_job_unittest.cc
[modify] https://crrev.com/1918ae78a8154c4dfc31fd238f9a00c53bbd96fd/net/url_request/url_request_file_job_unittest.cc
[modify] https://crrev.com/1918ae78a8154c4dfc31fd238f9a00c53bbd96fd/net/url_request/url_request_intercepting_job_factory.cc
[modify] https://crrev.com/1918ae78a8154c4dfc31fd238f9a00c53bbd96fd/net/url_request/url_request_intercepting_job_factory.h
[modify] https://crrev.com/1918ae78a8154c4dfc31fd238f9a00c53bbd96fd/net/url_request/url_request_job_factory.h
[modify] https://crrev.com/1918ae78a8154c4dfc31fd238f9a00c53bbd96fd/net/url_request/url_request_job_factory_impl.cc
[modify] https://crrev.com/1918ae78a8154c4dfc31fd238f9a00c53bbd96fd/net/url_request/url_request_job_factory_impl.h

Status: Fixed (was: Started)

Comment 3 by laforge@google.com, Nov 7 2017

Components: Internals>Network>Service

Comment 4 by laforge@google.com, Nov 7 2017

Components: -Internals>Network>Service Internals>Services>Network
Apologies, applied the wrong component in bulk.

Sign in to add a comment