New issue
Advanced search Search tips

Issue 706935 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

1.1%-3.2% regression in memory.top_10_mobile at 459427:459630

Project Member Reported by lanwei@chromium.org, Mar 30 2017

Issue description

See the link to graphs below.
 
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Mar 31 2017

Cc: vogelheim@chromium.org
Owner: vogelheim@chromium.org

=== Auto-CCing suspected CL author vogelheim@chromium.org ===

Hi vogelheim@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Daniel Vogelheim
  Commit : 8b8dfda8cfba652f5d9d21e44ce31f0478d08601
  Date   : Fri Mar 24 13:35:47 2017
  Subject: [parser/ast] Remove AstString, in favour of stand-alons Ast(Raw|Cons)String.

Bisect Details
  Configuration: android_one_perf_bisect
  Benchmark    : memory.top_10_mobile_stress
  Metric       : memory:chrome:all_processes:reported_by_chrome:v8:effective_size_avg/foreground/http_yandex_ru_touchsearch_text_science
  Change       : 0.02% | 7862987.14286 -> 7863380.28571

Revision                           Result                  N
chromium@459426                    7862987 +- 27589.4      14      good
chromium@459477                    7863059 +- 27467.6      14      good
chromium@459484                    7864885 +- 1249.18      6       good
chromium@459487                    7862893 +- 28196.5      14      good
chromium@459488                    7859430 +- 51775.6      21      good
chromium@459488,v8@f12b193df9      7862484 +- 38883.7      14      good
chromium@459488,v8@c10cde1959      7864114 +- 27739.5      9       good
chromium@459488,v8@c9da660928      7866353 +- 914.198      6       good
chromium@459488,v8@8b8dfda8cf      7851925 +- 25614.4      6       bad       <--
chromium@459488,v8@6141f6e216      7858966 +- 26644.3      9       bad
chromium@459489                    7859320 +- 35950.5      14      bad
chromium@459490                    7863334 +- 4290.46      14      bad
chromium@459502                    7863424 +- 3866.91      14      bad
chromium@459526                    7863380 +- 3316.0       14      bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests memory.top_10_mobile_stress

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8983671560721123456

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5319562842603520


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
Status: Assigned (was: Untriaged)
Oh. This regression is unexpected. I'll see if I can resolve it; if not I'll revert the CL (since this was a cleanup CL, so I guess we can live without.)
Status: Started (was: Assigned)
Status: Fixed (was: Started)
Fixed in https://codereview.chromium.org/2792353002.
Should now use slightly less memory than before. :)

Sign in to add a comment