New issue
Advanced search Search tips

Issue 706934 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

11.5%-13.1% regression in system_health.memory_mobile at 460449:460488

Project Member Reported by lanwei@chromium.org, Mar 30 2017

Issue description

See the link to graphs below.
 

Comment 1 by lanwei@chromium.org, Mar 30 2017

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=706934

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg7MXj0AgM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgnKq29QoM


Bot(s) for this bug's original alert(s):

android-webview-nexus5X
Cc: ericrk@chromium.org
Owner: ericrk@chromium.org

=== Auto-CCing suspected CL author ericrk@chromium.org ===

Hi ericrk@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : ericrk
  Commit : 8e3f651d6b76a33f580ea9811b64168610d3ebd4
  Date   : Wed Mar 29 18:22:31 2017
  Subject: Split image decode cache limits into "working set" vs "cache" limits

Bisect Details
  Configuration: android_webview_arm64_aosp_perf_bisect
  Benchmark    : system_health.memory_mobile
  Metric       : memory:webview:all_processes:reported_by_os:system_memory:proportional_resident_size_avg/browse_media/browse_media_facebook_photos
  Change       : 11.75% | 211931664.0 -> 236843024.0

Revision             Result                     N
chromium@460448      211931664 +- 5106615       6      good
chromium@460458      214152151 +- 12790574      9      good
chromium@460460      214501221 +- 9739675       6      good
chromium@460461      240619195 +- 33015267      6      bad       <--
chromium@460463      234160087 +- 40155950      9      bad
chromium@460468      239083707 +- 22430569      6      bad
chromium@460488      236843024 +- 30909142      6      bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-webview --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=browse.media.facebook.photos system_health.memory_mobile

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8983671874471043872

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5571913746743296


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
Status: Fixed (was: Untriaged)
My subsequent patch to drop image cache data on navigation has more than recovered this (expected) regression. Closing this out.

Sign in to add a comment