Follow up the CL:450892

https://chrome-internal-review.googlesource.com/c/450892

https://luci-milo.appspot.com/buildbot/chromeos/master-paladin/13986

At 8:16:37 pm March 17th, CL:450892 was rejected by master-paladin/13986:

"
CL:450892 depends on CL:*333910, which was not eligible (wrong manifest branch, wrong labels, or otherwise filtered from eligible set).
"

Looked into the sync stage log, CL:*333910 was filtered out:

"
20:24:17: INFO: Raw changes: CL:*332267 CL:*333888 CL:*333889 CL:*333910 CL:*333964 CL:*333987 CL:*337992 CL:*338404 CL:442835 CL:443407 CL:444250 CL:448112 CL:448396 CL:450872 CL:450892 CL:455281 CL:455369 CL:455370 CL:455371 CL:456442 CL:456482 CL:456483 CL:456789 CL:456861 CL:456900 CL:456923 CL:456979 CL:457120
20:24:17: INFO: Filtered changes: CL:*333964 CL:*337992 CL:*338404 CL:443407 CL:444250 CL:448112 CL:448396 CL:450872 CL:450892 CL:455281 CL:455369 CL:455370 CL:455371 CL:456442 CL:456482 CL:456483 CL:456789 CL:456861 CL:456900 CL:456923 CL:456979 CL:457120
"


It's because when the CQ picked CL:450892 (marked as pre_cq_passed on March 16th) and tried to created a transaction at 8:26:13 pm March 17th, CL:*333910 wasn't marked at CL_STATUS_PASSED in CLActionTable yet(CL:*333910 was marked as pre_cq_passed at 8:59:08 pm March 17th). 

CQ filtered out CL:*333910 because it's not passed and then rejected CL:450892 because it depended on CL:*333910 which wasn't in the change pool.

http://shortn/_gfeq8ECz67

Please find more context in  crbug.com/705023  comment #2 ~ #5





Another problem here is although CL:450892 was marked as pre_cq_passed on at 2017-03-16 04:11:40 (cidb timestamp) in CIDB clActionTable, it did got kicked out at 2017-03-18 02:16:23 (cidb timestamp). But GetCLPreCQStatusAndTime still treated it as pre_cq_passed because it only looked into entries in _PRECQ_ACTION_TO_STATUS and ignored actions like 'kicked_out'. Is this expected or a bug?

http://shortn/_sMKq3v1mNX