New issue
Advanced search Search tips

Issue 706919 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Sep 2017
Cc:
tkent@chromium.org
jeffcarp@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Task



Sign in to add a comment

Remove webkitpy/w3c/test_parser.py.

Project Member Reported by qyears...@chromium.org, Mar 30 2017 
Background: During the process of importing tests, the importer still parses files to check what type of file they are.

Now that we use MANIFEST.json to check what files are tests and what tests are reference tests while running the tests, I believe that this should be unnecessary now in general; we generally just want to copy over all files (with a few exceptions) and less the MANIFEST generator sort out which are files etc.

https://cs.chromium.org/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_copier.py?l=165
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 31 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/904a97549b34407f69820f1ff114c861f9c35bf6

commit 904a97549b34407f69820f1ff114c861f9c35bf6
Author: qyearsley <qyearsley@chromium.org>
Date: Fri Mar 31 03:30:57 2017

Remove usage of TestParser from test_copier.py.

This wouldn't yet allow us to remove TestParser, since it's also used
in wpt_expectations_updater.py currently.

BUG= 706919 

Review-Url: https://codereview.chromium.org/2786013003
Cr-Commit-Position: refs/heads/master@{#461013}

[modify] https://crrev.com/904a97549b34407f69820f1ff114c861f9c35bf6/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_copier.py
[modify] https://crrev.com/904a97549b34407f69820f1ff114c861f9c35bf6/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_copier_unittest.py

Comment 2 by foolip@chromium.org, Jul 3 2017

Components: Blink>Infra>Ecosystem

Comment 3 by foolip@chromium.org, Jul 3 2017

Components: -Blink>Infra>Predictability

Comment 5 by robertma@chromium.org, Sep 7 2017

Status: Fixed (was: Available)
►

Sign in to add a comment