GlobalCallbacks in tsmon don't work properly (in the context of sysmon) |
||||
Issue descriptionI added a series of new metrics in sysmon, and registered them as a GlobalCallback. After deploying them however, they never showed up in monarch. After redeploying them with r9719a8037ed28e0bb1f87f7267c7d25a6e23a20f (which changes them to non global callback), their streams finally started showing up. Here's sysmon versions over time for a bot: http://shortn/_9ApbdT06Sa And here's the docker metrics finally showing up after deploying the global fix: http://shortn/_El5X7HbFWf Looks pretty correlated. Could be I was holding it wrong, but it seems something is broken.
,
Apr 3 2017
,
Apr 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/external/github.com/luci/luci-go.git/+/82564cfcaebd57e7d65bb40997a050538a9845b8 commit 82564cfcaebd57e7d65bb40997a050538a9845b8 Author: dsansome <dsansome@chromium.org> Date: Mon Apr 03 23:48:21 2017 Make global callbacks usable outside appengine. This moves the ResetGlobalCallbackMetrics call inside tsmon's Flush, and adds a InvokeGlobalCallbacksOnFlush that defaults to true but is set to false on appengine. BUG= 706912 Review-Url: https://codereview.chromium.org/2795613002 [modify] https://crrev.com/82564cfcaebd57e7d65bb40997a050538a9845b8/appengine/tsmon/middleware.go [modify] https://crrev.com/82564cfcaebd57e7d65bb40997a050538a9845b8/common/tsmon/context.go
,
Apr 6 2017
,
Apr 6 2017
Confirmed; thanks Dave! |
||||
►
Sign in to add a comment |
||||
Comment 1 by bpastene@chromium.org
, Mar 30 2017