[A11y Assessment - NTP] Voice search time-out state doesn't provide keyboard access to Learn more and Close X |
|||||||||
Issue descriptionChrome Version: 57.0.2987.133 What steps will reproduce the problem? (1) Tab to Mic icon on NTP and Enter/Return (2) Wait until it times out and shows "Learn more" link (3) Use Tab key to select Learn more, and also Close X https://screenshot.googleplex.com/LaSZzzaQVRd.png What is the expected result? Learn more and Close X are accessed via keyboard navigation What happens instead? Can't be reached using keyboard
,
Sep 7 2017
In ChromeOS, mic icon does not appear on NTP. Version 62.0.3201.0 (Official Build) canary (64-bit)
,
Sep 8 2017
Mic icon not appearing on CrOS is unexpected; I've commented about that on bug 707004 . For the actual problem reported here: I guess we're missing tabIndexes on those elements.
,
Oct 16 2017
treib@ any idea who can own this? Hoping to gain traction as part of our PE sweep.
,
Oct 17 2017
over to treib for triage or assignment
,
Nov 29 2017
Looks like the voice overlay just doesn't handle keyboard focus at all so far - you just keep on tabbing through the elements in the base page, which aren't visible. Links for future reference: https://css-tricks.com/considerations-styling-modal/#modal-dom-and-a11y https://codepen.io/noahblon/pen/yJpXka
,
Dec 15 2017
,
Dec 15 2017
,
Dec 15 2017
The <dialog> element might be a good fit...
,
Dec 18 2017
Indeed, <dialog> looks like a perfect fit! Much nicer than the stuff from #6. I didn't know this exists! One potential caveat: <dialog> seems to be implemented in Chrome and Opera only, so it's possible that a11y tools like screenreaders won't handle it well.
,
Jan 11 2018
,
Jan 11 2018
,
Mar 2 2018
,
Mar 6 2018
Attached is a video of the current fix being reviewed here: https://chromium-review.googlesource.com/945146
,
Mar 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fe81a901e40dedf30d2f391073668f903b16d21d commit fe81a901e40dedf30d2f391073668f903b16d21d Author: kristipark <kristipark@chromium.org> Date: Thu Mar 08 23:18:00 2018 [Local NTP Voice] Implemented keyboard navigation for the voice search dialog Modified the voice overlay to be a dialog element, and expanded the keydown event handler to handle keydown events on buttons/links as click events. As a side effect, switching to a dialog element also fixes the fade in animation for the voice overlay. Bug: 706908 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I9dd79e21aa2b1f6c429e7f6d6957b18db2aa03a9 Reviewed-on: https://chromium-review.googlesource.com/945146 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#541924} [modify] https://crrev.com/fe81a901e40dedf30d2f391073668f903b16d21d/chrome/browser/resources/local_ntp/local_ntp.html [modify] https://crrev.com/fe81a901e40dedf30d2f391073668f903b16d21d/chrome/browser/resources/local_ntp/voice.css [modify] https://crrev.com/fe81a901e40dedf30d2f391073668f903b16d21d/chrome/browser/resources/local_ntp/voice.js [modify] https://crrev.com/fe81a901e40dedf30d2f391073668f903b16d21d/chrome/test/data/local_ntp/local_ntp_browsertest.html [modify] https://crrev.com/fe81a901e40dedf30d2f391073668f903b16d21d/chrome/test/data/local_ntp/voice_browsertest.html [modify] https://crrev.com/fe81a901e40dedf30d2f391073668f903b16d21d/chrome/test/data/local_ntp/voice_speech_browsertest.js [modify] https://crrev.com/fe81a901e40dedf30d2f391073668f903b16d21d/chrome/test/data/local_ntp/voice_text_browsertest.js
,
Mar 23 2018
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by leberly@chromium.org
, Sep 7 2017