New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 706890 link

Starred by 1 user
Status: Available
Owner: ----
Cc:
█ nednguyen@chromium.org
benjhayden@chromium.org
dproy@chromium.org
sullivan@chromium.org
crouleau@chromium.org
█ titovartem@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Update C++ perf test harnesses to produce Histograms natively

Project Member Reported by benjhayden@chromium.org, Mar 30 2017 
There are at least two C++ perf test harnesses:
 * PerfTimeLogger in //base/test/perf_log.cc
   https://codesearch.chromium.org/search/?q=PerfTimeLogger&sq=package:chromium&type=cs
 * //testing/perf/perf_test.cc
   https://codesearch.chromium.org/search/?q=%23include+%22testing/perf/perf_test.h%22&sq=package:chromium&type=cs

Can they be merged?

Either way, they need to be updated to allow perf tests such as cc_perftests to produce catapult-style Histograms within the next year: https://github.com/catapult-project/catapult/blob/master/docs/how-to-write-metrics.md#histograms

The existing Histogram class in base/metrics/histogram.h nearly fits catapult-style Histograms. It mostly just needs to be able to describe how its bins were built.
https://github.com/catapult-project/catapult/blob/master/tracing/tracing/value/histogram.html#L917

If we can add a pointer from a C++ Histogram to a C++ HistogramBinBoundaries object, that would allow serializing the boundary builder when the C++ Histogram is serialized. If a pointer would increase memory pressure (due to being multiplied by 5000 Histograms), then the perftest harness[es?] could use a subclass of Histogram instead.
(Extending base/metrics/histogram may be a separate blocking bug?)

Marking available because this is neither urgent nor high priority for me, but I wanted to go ahead and file it so that we can start designing and referring to it.
Project Member

Comment 1 by sheriffbot@chromium.org, Apr 2 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 2 by nednguyen@chromium.org, Apr 2 2018

Cc: benjhayden@chromium.org
Components: Speed>Benchmarks
Owner: ----
Status: Available (was: Untriaged)
This is still a good bug to tackle

Comment 3 by benjhayden@chromium.org, Oct 4

Cc: dproy@chromium.org
Summary: Update C++ perf test harnesses to produce Histograms natively (was: Update perf test harnesses)
Deep, are you planning on porting catapult Histograms to C++? Would that implementation be suitable for use in C++ perf tests?

Comment 4 by nedngu...@google.com, Oct 4

Cc: crouleau@chromium.org

Comment 5 by dproy@chromium.org, Oct 4 

Yes, I'll have to port catapult histograms to C++ to add perfetto metrics to the perf dashboard. Not exactly sure about the exact timeline yet, but my guess is either Q4 this year or Q1 next year.

Comment 6 by benjhayden@chromium.org, Oct 4 

Thanks! Can you please CC me on the CLs?
When it starts to take shape, let's meet with benchmarking team to discuss migrating c++ perf tests to it.

Comment 7 by crouleau@chromium.org, Oct 4 

I'm interested in this migration as well (and I just joined the benchmarking team).

Comment 8 by dproy@chromium.org, Oct 5 

benjhayden@: Of course! Will let everyone know when the work starts.

Comment 9 by benjhayden@chromium.org, Oct 25

Cc: titovartem@chromium.org
+Artem, please watch this bug to know when you can start switching your C++ tests to produce Histograms directly.

Comment 10 by eakuefner@chromium.org, Nov 12

Cc: -eakuefner@chromium.org
►

Sign in to add a comment