New issue
Advanced search Search tips

Issue 706870 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Jul 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

1%-1.7% regression in system_health.memory_mobile at 459451:459597

Project Member Reported by lanwei@chromium.org, Mar 30 2017

Issue description

See the link to graphs below.
 
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Mar 31 2017

Cc: verwa...@chromium.org
Owner: verwa...@chromium.org

=== Auto-CCing suspected CL author verwaest@chromium.org ===

Hi verwaest@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Toon Verwaest
  Commit : 885f0bc4a77692e5aa3b2c0cad0c9f5b3ada3796
  Date   : Fri Mar 24 14:37:29 2017
  Subject: [csa] Support typed arrays in Has(Own)Property

Bisect Details
  Configuration: android_nexus5_perf_bisect
  Benchmark    : system_health.memory_mobile
  Metric       : memory:chrome:all_processes:reported_by_chrome:v8:effective_size_avg/load_news/load_news_hackernews
  Change       : 0.47% | 2157213.14286 -> 2167349.77778

Revision                           Result                  N
chromium@459475                    2157213 +- 25527.0      14      good
chromium@459483                    2157082 +- 20785.2      9       good
chromium@459487                    2157087 +- 20757.7      9       good
chromium@459488                    2155228 +- 19201.6      6       good
chromium@459488,v8@f12b193df9      2159279 +- 19227.0      6       good
chromium@459488,v8@6141f6e216      2166096 +- 20730.3      9       good
chromium@459488,v8@565829f580      2165980 +- 25533.2      14      good
chromium@459488,v8@885f0bc4a7      2167875 +- 29980.6      21      bad       <--
chromium@459488,v8@dae6e43d38      2168673 +- 21753.4      14      bad
chromium@459489                    2169204 +- 15667.7      9       bad
chromium@459491                    2169208 +- 15719.5      9       bad
chromium@459506                    2167087 +- 32464.2      21      bad
chromium@459536                    2168667 +- 21777.4      14      bad
chromium@459597                    2167350 +- 20785.2      9       bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=load.news.hackernews system_health.memory_mobile

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8983677739632607568

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5718028433489920


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
Owner: ----
Kinda looks like it should have bisected in between these:

chromium@459488,v8@f12b193df9      2159279 +- 19227.0      6       good
chromium@459488,v8@6141f6e216      2166096 +- 20730.3      9       good <- bad?

I'll restart it.
That's what it seems like to me indeed, but then again, there are revisions around that revision that weren't measured; and it seems unlikely that that particular version caused this increase (even though it does increase memory usage somewhat).

=== BISECT JOB RESULTS ===
Perf regression found but unable to narrow commit range

Build failures prevented the bisect from narrowing the range further.


Bisect Details
  Configuration: android_nexus6_perf_bisect
  Benchmark    : system_health.memory_mobile
  Metric       : memory:chrome:all_processes:reported_by_chrome:malloc:effective_size_avg/load_search/load_search_taobao
  Change       : 1.12% | 35538981.7778 -> 35938011.1111

Suspected Commit Range
  16 commits in range
  Mismatching LKGR/FKBR depots, unable to provide handy url.
  good_revision: v8@f12b193df9134ba3a1ef565a8c799f19060205af
  bad_revision : chromium@c6aafdcefd3e6c7abcdc205d46c0c2a3e0c8be58


Revision                           Result                   N
chromium@459450                    35538982 +- 1464432      9        good
chromium@459470                    35523008 +- 1019837      6        good
chromium@459480                    35779612 +- 322131       6        good
chromium@459485                    35797281 +- 318607       6        good
chromium@459487                    35764269 +- 271684       6        good
chromium@459488                    35087532 +- 1043859      5        good
chromium@459488,v8@f12b193df9      34853296 +- 495785       11       good
chromium@459488,v8@dc00a1216f      ---                      ---      build failure
---                                ---                      ---      too many build failures to list
chromium@459488,v8@417c83c1b1      ---                      ---      build failure
chromium@459489                    35554521 +- 2240910      11       bad
chromium@459528                    35938011 +- 1172870      9        bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=load.search.taobao system_health.memory_mobile

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8977345685145043648

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=6510211616997376


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
Status: WontFix (was: Untriaged)
This alert was found before M-60 branched. Closing as WontFix as this is believed to either be invalid or non-reproducible. 

Sign in to add a comment